This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
NET-4954: Remove/replace noncompliant actions #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
the
pr/no-changelog
nathancoleman
changed the title
nathancoleman
added
the
pr/conformance
We no longer use this due to permissions limitations on the token provided by Actions which does not have SSO enabled
nathancoleman
force-pushed
the
tsccr-cleanup
branch
from
0fc4328
to
33700ba
Compare
nathancoleman
commented
Jul 19, 2023
| required: false | ||
| type: string # No support for numeric value | ||
| default: '10' | ||
| workflow_dispatch: {} |
There was a problem hiding this comment.
The inputs were only used for controlling the tmux action, which we're no longer able to use
| if: always() && github.ref == 'refs/heads/main' | ||
| uses: ravsamhq/notify-slack-action@v1 # TSCCR: no entry for repository "ravsamhq/notify-slack-action" |
There was a problem hiding this comment.
This is being replaced by the official Slack action that now exists
There was a problem hiding this comment.
Changes in this file mirror those in the conformance.yml file above, just without the Slack notification since this one runs on PRs
There was a problem hiding this comment.
We've been unable to use this workflow for several releases now due to the default token assigned by GitHub Actions not having SSO enabled. Since we're not actively developing/releasing this repo anymore, I opted to just remove the workflow
missylbytes
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
🤖 tests pass (including conformance)
How I expect reviewers to test this PR:
See above
Checklist: