add support for writing events via the context #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2021
louisruch
reviewed
Jun 4, 2021
Co-authored-by: Louis Ruch <[email protected]>
…ent_test pkg in context_test.go
|
I pushed a commit (9c7ac25) which refactored a few bits which allowed me to stop exporting a few things. Sorry if it clutters up the PR a bit, but it's all simple stuff. |
vancluever
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is third of 3 PRs to add the events package and they should be reviewed in order. Before this was #1275 and #1276.
This PR will be merged into the branch for #1276, which will be merged to the branch for #1275, which will be merged intowhen all three have been reviewed/approved.