base types for events package #1275
Conversation
|
|
@mgaffney @s-christoff added a commit with godoc comments for exported fields except for the unratified audit related fields and/or structs. Ty for the suggestion! |
There was a problem hiding this comment.
Agreeing with @mgaffney's points for sure re: comments and package naming (although some of these could be addressed now as I have not hit "refresh" yet 😜 )
Also some other things that need fixing including a test where an assertion seems to be getting missed.
… "event" dir right before merging.
|
I've rolled back the directory name change for now... it will be reapplied before merging but it was causing all sorts of conflicts with the upstream PRs |
There was a problem hiding this comment.
Just want to bring up as a minor point https://github.com/hashicorp/boundary/pull/1275/files#r645785137 (the thread over WithNow and how it might be better as WithTime since this option is not actually deriving or enforcing a current time.
This is first of 3 PRs to add the events package and they should be reviewed in order. After this one, then #1276 and #1277.
This PR will be merged into main after the last one in the series (#1277) has been approved.
BTW, none of these 3 PRs will affect any of the rest of Boundary. They are stand-alone infrastructure for eventing audits, errors, and observations. Subsequent PRs may change how some of this infrastructure works and we work to integrating the events package with the rest of Boundary and we continue to receive feedback from the Event Logging RFCs.