Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore icu 9958 storybook patch babel v7 mode #1748

Closed
wants to merge 15 commits into from

Conversation

calcaide
Copy link
Collaborator

@calcaide calcaide commented Jun 28, 2023

🎟️ Jira ticket

Description

  • Update @storybook/* to 6.4.x.
  • After the updates, we re-audit specific resoltions for @storybook. Resulting in a bunch of them being deleted.
  • Missing migrate storybook to babel mode v7, as mentioned in the Jira ticket. We will attempt this later when upgrading other deps because we run into dependency issues when attempted.

How to test this PR:

After every commit, the test procedure it's been building and running @storybook succesfully.

@calcaide calcaide self-assigned this Jun 28, 2023
@calcaide calcaide requested a review from a team as a code owner June 28, 2023 21:52
@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
boundary-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 29, 2023 10:34pm
boundary-ui-desktop βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 29, 2023 10:34pm
boundary-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 29, 2023 10:34pm

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!! Thanks for doing this upgrade work!

"@storybook/components": "^6.3.12",
"@storybook/core-events": "^6.3.0",
"@storybook/ember": "6.4.0",
"@storybook/addon-docs": "~6.4.0",
Copy link
Collaborator

@ZedLi ZedLi Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to be pinned to patch version, does it work fine now on ^6.4.0? I previously had issues when it was on 6.5.x

Somewhat related, should it actually be 6.5.x for some of these packages in package.json since it looks like some of them are now resolving to 6.5.x anyways as that meets the ^6.4.0 requirements

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZedLi

Awesome questions!!

@storybook/addons-docs is getting important changes/deprecations within 6.5, here more information about it. So to minimize noise within this PR I was trying to keep it pined with ~. But definitely planning on deprecation work and upgrade @storybook/addons-doc to 6.5.


Absolutely agreed with your second comment.

Upgrading storybook it's hard and easy to get lost within dependencies of dependencies.Β 
After trying different strategies without much success, pining the main dependencies, such as @storybook/ember, and troublesome dependencies, such as @storybook/docs while being more open with ^ in the rest of them, brings less bugs/noise to validate the entire storybook works after an upgrade. Also facilitates deprecation work.

Then, as you mention, we resolve higher versions than we specify, i.e: we declare @storybook/depA: ^6.4.0 and we resolve @storybook/[email protected]. But re-declaring those, sometimes ends in unexpected bugs/noise and loops of frustration.Β 

In a nutshell, I am trying to "box" the storybook upgrades efforts in a way that we do baby steps = PR, validate it, and move to the next step (which will be upgrade to ^6.5.x @storybook deps).

Happy to discuss this over slack of zoom πŸ˜‰

@calcaide
Copy link
Collaborator Author

calcaide commented Jul 4, 2023

Closing this PR due to issues when trying to upgrade @storybook. After upgrading it, some magic on the dependencies start making our test that uses sinon.stub to fail.
Spend time debugging and trying to fix it, no luck with it so closing this.

@calcaide calcaide closed this Jul 4, 2023
@calcaide calcaide deleted the chore-ICU-9958-storybook-patch-babel-v7-mode branch July 25, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants