Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 Pin storybook docs addon to a minor version #1631

Merged
merged 3 commits into from
Feb 15, 2023
Merged

chore: 🤖 Pin storybook docs addon to a minor version #1631

merged 3 commits into from
Feb 15, 2023

Conversation

ZedLi
Copy link
Collaborator

@ZedLi ZedLi commented Feb 10, 2023 •
edited
Loading

The storybook docs addon is broken in 6.5.x currently. Pinning it to 6.3.x lets us to continue using storybook. See this github issue: storybookjs/storybook#17527

✅ Closes: ICU-7791

🎟️ Jira ticket

Description

🌹 Rose preview

@ZedLi
chore: 🤖 Pin storybook docs addon to a minor version
77f60bb 
The storybook docs addon is broken in 6.5.x currently. Pinning it to
6.3.x lets us to continue using storybook. See this github issue:
storybookjs/storybook#17527

✅ Closes: ICU-7791
@ZedLi ZedLi requested a review from a team as a code owner February 10, 2023 20:14
@ZedLi ZedLi self-assigned this Feb 10, 2023
@vercel
Copy link

vercel bot commented Feb 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 7:06PM (UTC)
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 7:06PM (UTC)
boundary-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 7:06PM (UTC)

calcaide
calcaide approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!! yeah seems like the best we could do to guarantee Storybook stability for deps is to pin versions 👍

@ZedLi ZedLi merged commit 76147af into main Feb 15, 2023
@ZedLi ZedLi deleted the ICU-7791-storybook-is-broken branch February 15, 2023 19:41
@ZedLi ZedLi mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronperera cameronperera cameronperera approved these changes

@DhariniJeeva DhariniJeeva DhariniJeeva approved these changes

@calcaide calcaide calcaide approved these changes

Assignees

@ZedLi ZedLi

Labels
addons styles-addon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZedLi @calcaide @DhariniJeeva @cameronperera