feat: introduce process lock so that solo doesn't allow parallel execution of commands #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leninmehedy
changed the title
E2E Test Results 1 files ± 0 6 suites ±0 4m 48s ⏱️ - 7m 30s For more details on these failures, see this check. Results for commit 7f537b6. ± Comparison against base commit f4f8527. This pull request removes 700 and adds 700 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
leninmehedy
force-pushed
the
00043-avoid-sleep-or-use-toggle
branch
3 times, most recently
from
b6d9227 to
4abb500
Compare
leninmehedy
changed the title
leninmehedy
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 63.72% 67.05% +3.32%
==========================================
Files 27 27
Lines 2553 2477 -76
Branches 371 363 -8
==========================================
+ Hits 1627 1661 +34
+ Misses 926 816 -110
... and 1 file with indirect coverage changes |
leninmehedy
force-pushed
the
00043-avoid-sleep-or-use-toggle
branch
6 times, most recently
from
dc5af56 to
75aefc0
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation Footnotes
|
leninmehedy
force-pushed
the
00043-avoid-sleep-or-use-toggle
branch
2 times, most recently
from
2fe8380 to
6833573
Compare
leninmehedy
force-pushed
the
00043-avoid-sleep-or-use-toggle
branch
6 times, most recently
from
84b657a to
54f11a5
Compare
leninmehedy
force-pushed
the
00043-avoid-sleep-or-use-toggle
branch
from
0868d21 to
2ccc09f
Compare
leninmehedy
changed the title
leninmehedy
changed the title
leninmehedy
force-pushed
the
00043-avoid-sleep-or-use-toggle
branch
2 times, most recently
from
167f4a0 to
e4cb5e0
Compare
jeromy-cannon
previously approved these changes
Feb 28, 2024
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
00043-avoid-sleep-or-use-toggle
branch
from
e4cb5e0 to
7f537b6
Compare
|
We need to introduce cluster level lock instead of local process lock #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
relaycommand argument parsing and chart nameExample:
Related Issues