fix: separate out command error handler

Signed-off-by: Lenin Mehedy <[email protected]>

src/commands/base.mjs

@@ -19,6 +19,20 @@ import { FullstackTestingError, MissingArgumentError } from '../core/errors.mjs'
 import { ConfigManager } from '../core/index.mjs'
 import { ShellRunner } from '../core/shell_runner.mjs'
 
+/**
+ * This is a default command error handler used by handleCommand
+ * @param err error
+ * @param logger logger
+ */
+const defaultErrorHandler = (err, logger) => {
+  logger.showUserError(err)
+
+  // do not exit immediately so that logger can flush properly
+  setTimeout(() => {
+    process.exit(1)
+  }, 1)
+}
+
 export class BaseCommand extends ShellRunner {
   async prepareChartPath (chartDir, chartRepo, chartName) {
     if (!chartRepo) throw new MissingArgumentError('chart repo name is required')
@@ -57,9 +71,10 @@ export class BaseCommand extends ShellRunner {
    *
    * @param argv argv of the command
    * @param handleFunc async function to be invoked
-   * @return {Promise<boolean>} true if the execution succeeded
+   * @param errHandler error handler
+   * @return {Promise<void>}
    */
-  async handleCommand (argv, handleFunc) {
+  async handleCommand (argv, handleFunc, errHandler = defaultErrorHandler) {
     if (!argv) throw new MissingArgumentError('argv is required')
     if (!handleFunc) throw new MissingArgumentError('handleFunc is required')
 
@@ -76,16 +91,7 @@ export class BaseCommand extends ShellRunner {
     }
 
     if (error) {
-      this.logger.showUserError(error)
-
-      // do not exit immediately so that logger can flush properly
-      setTimeout(() => {
-        process.exit(1)
-      }, 1)
-
-      return false // we return false here, but process will exit with error code eventually.
+      return errHandler(error, this.logger)
     }
-
-    return true
   }
 }