Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for genesis throttle configuration #1026

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

nathanklick
Copy link
Member

@nathanklick nathanklick commented Dec 27, 2024

Description

This pull request changes the following:

  • Adds a new --genesis-throttles-file option to the solo network deploy command
  • Updates the Helm chart version required
  • Refactors the name of several taskfiles
  • Refactors the name of the Latitude folder to latitude

Related Issues

@nathanklick nathanklick self-assigned this Dec 27, 2024
@nathanklick nathanklick added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Dec 27, 2024
@nathanklick nathanklick marked this pull request as ready for review December 27, 2024 17:41
@nathanklick nathanklick requested review from leninmehedy and a team as code owners December 27, 2024 17:41
Copy link
Contributor

github-actions bot commented Dec 27, 2024

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   3s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 294742d. ± Comparison against base commit 5edb9c9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   13s ⏱️ ±0s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 294742d. ± Comparison against base commit 5edb9c9.

♻️ This comment has been updated with latest results.

jeromy-cannon
jeromy-cannon previously approved these changes Dec 27, 2024
tomzhenghedera
tomzhenghedera previously approved these changes Dec 27, 2024
tomzhenghedera
tomzhenghedera previously approved these changes Dec 27, 2024
@nathanklick nathanklick force-pushed the 00933-Throttle-Config branch 3 times, most recently from 23a58cf to 17e7404 Compare January 3, 2025 17:29
@nathanklick nathanklick requested review from a team as code owners January 3, 2025 22:23
@nathanklick nathanklick requested a review from rbarkerSL January 3, 2025 22:23
@nathanklick nathanklick force-pushed the 00933-Throttle-Config branch from d0b1959 to 294742d Compare January 3, 2025 22:23
Copy link
Contributor

github-actions bot commented Jan 3, 2025

E2E Test Report

 16 files  121 suites   1h 20m 22s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs  261 ✅ 0 💤 0 ❌

Results for commit 294742d.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 3, 2025

E2E Test Report

 16 files  121 suites   1h 20m 22s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs  261 ✅ 0 💤 0 ❌

Results for commit 294742d.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5edb9c91 54.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5edb9c9) Report Missing Report Missing Report Missing
Head commit (294742d) 20038 17137 85.52%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1026) 75 41 54.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 54.66667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (1297cb5) to head (294742d).
Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
src/core/helpers.ts 26.19% 31 Missing ⚠️
src/commands/network.ts 88.88% 2 Missing ⚠️
src/core/certificate_manager.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
- Coverage   84.76%   84.66%   -0.10%     
==========================================
  Files          76       76              
  Lines       19970    20038      +68     
  Branches     1253     1687     +434     
==========================================
+ Hits        16928    16966      +38     
+ Misses       3022     2959      -63     
- Partials       20      113      +93     
Files with missing lines Coverage Δ
src/commands/flags.ts 73.71% <100.00%> (+0.18%) ⬆️
version.ts 100.00% <100.00%> (ø)
src/core/certificate_manager.ts 51.85% <0.00%> (ø)
src/commands/network.ts 72.47% <88.88%> (+0.29%) ⬆️
src/core/helpers.ts 81.86% <26.19%> (-6.80%) ⬇️

... and 23 files with indirect coverage changes

Impacted file tree graph

@nathanklick nathanklick merged commit d8903a8 into main Jan 4, 2025
41 of 44 checks passed
@nathanklick nathanklick deleted the 00933-Throttle-Config branch January 4, 2025 21:36
swirlds-automation added a commit that referenced this pull request Jan 13, 2025
## [0.33.0](v0.32.0...v0.33.0) (2025-01-13)

### Features

* add support for genesis throttle configuration ([#1026](#1026)) ([d8903a8](d8903a8))
* enable Blockstreams and uploader ([#1109](#1109)) ([ed6527b](ed6527b))
* inspect existing cluster resources during cluster setup ([#1094](#1094)) ([808516c](808516c))
* production readiness pass custom mirror node postgresql credentials and server address ([#1128](#1128)) ([f8b7e41](f8b7e41))
* support using GCS for backup uploader ([#1130](#1130)) ([5fe2f4e](5fe2f4e))
* update genesis-network.json to add roster entries and more ([#1122](#1122)) ([c27d1d6](c27d1d6))
* Updating solo to leverage changes after moving acme-cluster-issuer and haproxy-ingress out of mirror-node-explorer ([#1079](#1079)) ([7965894](7965894))
* use gcs for stream file storage ([#994](#994)) ([04d5806](04d5806))

### Bug Fixes

* add missing images, fix debug page images ([#1092](#1092)) ([4073d31](4073d31))
* Bug when running `solo cluster connect` after fresh install ([#1123](#1123)) ([1cd0e28](1cd0e28))
* bump solo-charts to 0.42.2 to pull in blockStreams fix ([#1138](#1138)) ([c482895](c482895))
* bump versions of hedera, json rpc relay, and mirror node ([#1147](#1147)) ([0784b46](0784b46))
* clarify how to use nvm ([#1125](#1125)) ([bdc1873](bdc1873))
* commit message of auto update ([#1106](#1106)) ([a3231f9](a3231f9))
* external link rendering ([#1118](#1118)) ([28af1fe](28af1fe))
* file size empty error when throttle file is provided on command line ([#1140](#1140)) ([5180a76](5180a76))
* fixed release artifact version issue and updated readme link ([#1090](#1090)) ([84e6611](84e6611))
* **lease:** reworks the previous fix addressing renewal issues ([#1105](#1105)) ([5edb9c9](5edb9c9))
* should run `npm install` before build ([#1117](#1117)) ([3398875](3398875))
* solo deployment create should use email address in local config if it is already there instead of prompting the user for it ([#1112](#1112)) ([362df60](362df60))
* started adding a yachli example and taskfile ([#1132](#1132)) ([8753723](8753723))
* update to AccountManager._getNodeClient() to parallel node connection setup ([#1091](#1091)) ([4959a12](4959a12))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released on @0.33.x released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production Readiness: Ability to specify custom throttle configuration file
6 participants