Feature flag for create2 verification support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svienot
force-pushed
the
configurable-create2-support
branch
from
0d6621e
to
3585c71
Compare
Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
svienot
force-pushed
the
configurable-create2-support
branch
from
3585c71
to
a5e95a9
Compare
Nana-EC
requested changes
Oct 18, 2023
…e flag for create2 endpoints. Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
svienot
force-pushed
the
configurable-create2-support
branch
2 times, most recently
from
5ef8def
to
f3c02a6
Compare
Signed-off-by: Simon Viénot <[email protected]>
Nana-EC
approved these changes
Oct 19, 2023
|
Is there a way to disable the related endpoints in the Swagger UI when This is because otherwise these endpoints return <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Error</title>
</head>
<body>
<pre>Cannot POST /verify/create2</pre>
</body>
</html>This is how it's seen in the Swagger API 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This brings changes in the ui and in the server:
In the UI, Create2 verification will only be available when the following is added to
config.json:"CREATE2_VERIFICATION": trueNote: When Create2 is activated, the TOKEN parameter will no longer be required in the UI since it does not seem to be needed and is quite confusing.
In the server, the API endpoints related to Create2 support will be exposed only if the following environment variable is defined:
SERVER_CREATE2_VERIFICATION=true