Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and config #24

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Update readme and config #24

merged 8 commits into from
Aug 18, 2023

Conversation

svienot
Copy link
Contributor

@svienot svienot commented Aug 18, 2023

Description:

  • do a bit of clean-up and clarification of the variables in the various .env.*.hedera files
  • add a $UI_DOMAIN_NAME environment variables used to configure CORS in the server (needed if the ui has to run on a different host than the server).
  • removing build directives from the yaml files unrelated to build (the files build-xxx.yaml) can be used instead.
  • adding info in README about working with Docker images.

Notes for reviewer:

This branch currently deployed on the POC server.

@Nana-EC Nana-EC added this to the 0.1.0 milestone Aug 18, 2023
@Nana-EC Nana-EC added the Improvement Code changes driven by non business requirements label Aug 18, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
A question

environments/.env.server.hedera Show resolved Hide resolved
@svienot svienot merged commit a55df13 into main Aug 18, 2023
1 check passed
@svienot svienot deleted the update-readme-and-config branch August 18, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants