Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip broken unit test for contract-call-decoder #163

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: skip broken unit test for contract-call-decoder #163

merged 1 commit into from
Apr 19, 2024

Conversation

acuarica
Copy link
Contributor

Description:

This PR fixes #162.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica
Skip broken test
850915c 
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica requested review from a team as code owners April 19, 2024 16:00
@acuarica acuarica linked an issue Apr 19, 2024 that may be closed by this pull request
Fix broken unit test for contract-call-decoder #162
Closed
@acuarica acuarica requested review from ericleponner and removed request for a team April 19, 2024 16:00
@acuarica acuarica changed the title Skip broken unit test for contract-call-decoder fix: skip broken unit test for contract-call-decoder Apr 19, 2024
david-bakin-sl
david-bakin-sl approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. (I assume we have some kind of process that goes through and fixes these .skips when appropriate?)

@acuarica acuarica merged commit 66148ae into main Apr 19, 2024
8 of 9 checks passed
@acuarica acuarica deleted the 162-fix-broken-unit-test-for-contract-call-decoder branch April 19, 2024 16:12
@acuarica
Copy link
Contributor Author

We will remove these tests once we start using upstream Sourcify images (server and repository) directly since they won't be needed.

@acuarica acuarica added the bug A error that causes the feature to behave differently than what was expected based on design docs label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-bakin-sl david-bakin-sl david-bakin-sl approved these changes

@ericleponner ericleponner Awaiting requested review from ericleponner ericleponner is a code owner automatically assigned from hashgraph/dev-experience

Assignees
No one assigned
Labels
bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken unit test for contract-call-decoder
2 participants
@acuarica @david-bakin-sl