-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused config files #159
chore: remove unused config files #159
Conversation
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
@svienot @rustyShacklefurd I would like your input here, is there something else we should remove? |
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
These configs have been superseded by `docker-compose-hedera.yaml`. Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
This looks good.
|
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
@svienot @rustyShacklefurd when you have a bit of time, please take a look at this PR, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (nice clean-up) !
Description:
This PR cleans up the repo by removing unused files coming from Sourcify.
.circleci
this is used by upstream Sourcify, not us.vscode
andui/.vscode
unused launch configurationstslint.json
old lint settings, superseded by.eslintrc.js
f855a1cservices/ipfs
unused image, see https://docs.sourcify.dev/docs/repository/#ipfsservices/s3sync
unused image, see https://docs.sourcify.dev/docs/repository/#s3-bucketsome files from
scripts/
that might be used by upstream Sourcify 78c4de9, 93b5dde and ca75ec2.github/PULL_REQUEST_TEMPLATE/release.md
unused PR template ad266cdscripts/hedera-reset-(previewnet|testnet).sh
invokehedera-reset.sh
directly frompackage.json
'sscripts
to avoid indirection andscripts
folder pollution 9de95ddenvironments/(build-)?(ipfs|monitor|s3).yaml
docker related configs for unused services a61b2ebmonitor
service related files c04daf2environments/(grafana|loki-config|promtail-config).yaml
satellite service configs 0740bc2environments/(repository|server|ui).yaml
Hederacompose
configs superseded bydocker-compose-hedera.yaml
b8068f7environments/.env.(dev|latest|stable)
upstream Sourcify.env
config files not used by Hedera 51eed0eenvironments/.env.secrets.gpg
unused secrets b3fe100 and related config files 8fa438dui/.env.(development|production)
old env var templates and updateui/.gitignore
accordingly 99a009aThis PR is a pre-step towards issue #147, where upstream Sourcify images will be consumed directly (except
ui
).The
ui
's landing page is also unused and needs to be removed. However, because removing a page would also require updating theui/package.json
's dependencies, its removal is implemented as part of #160.Related issue(s):
Fixes #142.
Notes for reviewer:
The amount of files removed in this PR got larger then I expected. As a recommendation, it might be easier for reviewers to look at each commit individually. Moreover, next to each item is the commit that delete it.