Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused config files #159

Merged
merged 14 commits into from
Apr 24, 2024

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Apr 17, 2024

Description:

This PR cleans up the repo by removing unused files coming from Sourcify.

  • .circleci this is used by upstream Sourcify, not us
    .vscode and ui/.vscode unused launch configurations
    tslint.json old lint settings, superseded by .eslintrc.js f855a1c
  • services/ipfs unused image, see https://docs.sourcify.dev/docs/repository/#ipfs
    services/s3sync unused image, see https://docs.sourcify.dev/docs/repository/#s3-bucket
    some files from scripts/ that might be used by upstream Sourcify 78c4de9, 93b5dde and ca75ec2
  • .github/PULL_REQUEST_TEMPLATE/release.md unused PR template ad266cd
  • scripts/hedera-reset-(previewnet|testnet).sh invoke hedera-reset.sh directly from package.json's scripts to avoid indirection and scripts folder pollution 9de95dd
  • environments/(build-)?(ipfs|monitor|s3).yaml docker related configs for unused services a61b2eb
  • monitor service related files c04daf2
  • environments/(grafana|loki-config|promtail-config).yaml satellite service configs 0740bc2
  • environments/(repository|server|ui).yaml Hedera compose configs superseded by docker-compose-hedera.yaml b8068f7
  • environments/.env.(dev|latest|stable) upstream Sourcify .env config files not used by Hedera 51eed0e
  • environments/.env.secrets.gpg unused secrets b3fe100 and related config files 8fa438d
  • ui/.env.(development|production) old env var templates and update ui/.gitignore accordingly 99a009a

This PR is a pre-step towards issue #147, where upstream Sourcify images will be consumed directly (except ui).

The ui's landing page is also unused and needs to be removed. However, because removing a page would also require updating the ui/package.json's dependencies, its removal is implemented as part of #160.

Related issue(s):

Fixes #142.

Notes for reviewer:

The amount of files removed in this PR got larger then I expected. As a recommendation, it might be easier for reviewers to look at each commit individually. Moreover, next to each item is the commit that delete it.

Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica linked an issue Apr 17, 2024 that may be closed by this pull request
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica
Copy link
Contributor Author

@svienot @rustyShacklefurd I would like your input here, is there something else we should remove?

Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
These configs have been superseded by `docker-compose-hedera.yaml`.

Signed-off-by: Luis Mastrangelo <[email protected]>
@svienot
Copy link
Contributor

svienot commented Apr 19, 2024

@svienot @rustyShacklefurd I would like your input here, is there something else we should remove?

This looks good.
I guess we might as well get rid of a couple more scripts:

  • decrypt.sh
  • encrypt.sh
  • find_replace.sh

Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica marked this pull request as ready for review April 19, 2024 17:59
@acuarica acuarica requested review from a team as code owners April 19, 2024 17:59
@acuarica acuarica requested review from quiet-node, Sheng-Long, svienot, rustyShacklefurd and ericleponner and removed request for a team April 19, 2024 17:59
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica
Copy link
Contributor Author

@svienot @rustyShacklefurd when you have a bit of time, please take a look at this PR, thanks.

Copy link
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (nice clean-up) !

@acuarica acuarica merged commit fbbbd17 into main Apr 24, 2024
9 of 10 checks passed
@acuarica acuarica deleted the 142-clean-up-unused-files-and-services-from-the-repo branch April 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up unused files and services from the repo
2 participants