-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include support for metrics #131
Conversation
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Just naming suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
I like that you used the express-prom-bundle and did not had to do things from scratch! 💯
Signed-off-by: Luis Mastrangelo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description:
This PR adds another endpoint,
/metrics
, where you can fetch service metrics to be ingested by Prometheus/Grafana.Using for instance the NodeJS Application Dashboard you can see NodeJS metrics
It also exports requests and events (response) triggered during verification. All requests made to the service (e.g. https://server-verify.hashscan.io/api-docs) will be included, for example
Note that the
sourcify_
prefix is used all metrics to easily differentiate in Grafana.The events exported are
(the ones omitted
[...]
areMonitor.*
related not used at the moment)Related issue(s):
Fixes #
Notes for reviewer:
Checklist