Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building repository image on Apple M-chips #104

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix building repository image on Apple M-chips #104

merged 1 commit into from
Dec 13, 2023

Conversation

acuarica
Copy link
Contributor

Description:

This PR updates the h5ai-nginx submodule which already fixed building the repository image on Apple M-chips.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica requested review from a team as code owners December 13, 2023 18:03
@acuarica acuarica linked an issue Dec 13, 2023 that may be closed by this pull request
Fail to build repository image on Apple ARM-based chips (M1, M2) #103
Closed
svienot
svienot approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

ericleponner
ericleponner approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repository now builds correctly on my Apple M1.

@acuarica acuarica merged commit 77d3565 into main Dec 13, 2023
5 checks passed
@acuarica acuarica deleted the 103-fail-to-build-repository branch December 13, 2023 19:20
@acuarica acuarica mentioned this pull request Apr 5, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

@svienot svienot svienot approved these changes

@quiet-node quiet-node Awaiting requested review from quiet-node quiet-node is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to build repository image on Apple ARM-based chips (M1, M2)
3 participants
@acuarica @svienot @ericleponner