Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repository lookup select contract form #100

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: repository lookup select contract form #100

merged 1 commit into from
Dec 13, 2023

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Dec 12, 2023 •
edited by Nana-EC
Loading

Description:

Use checksummed address lookup in the repository select-contract-form. This allows the user to use the form with non-checksummed addresses.

Related issue(s):

Fixes #91

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica requested review from a team as code owners December 12, 2023 17:52
@acuarica acuarica linked an issue Dec 12, 2023 that may be closed by this pull request
Hedera Sourcify search views have different behavior #91
Closed
@acuarica acuarica requested review from Sheng-Long, svienot and ericleponner and removed request for a team December 12, 2023 17:52
@acuarica
Copy link
Contributor Author

@Nana-EC @svienot The PR diff looks like a lot has changed, but I only added some lines in App.js and package.json. This is because IntelliJ reordered the files within the patch.

Shall we use a different approach, e.g., git diff to generate the patch consistently?

Nana-EC
Nana-EC approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

svienot
svienot approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well.

@acuarica acuarica mentioned this pull request Dec 12, 2023
Closed
@acuarica
Copy link
Contributor Author

Looks good, works well.

@svienot just to double-check, did you manage to verify that this PR works as expected? Applying the patch, building the image and make a lookup in the repository?

If that's the case, I will go ahead and merge this. I wasn't able to verify it myself because of #103.

@svienot
Copy link
Contributor

svienot commented Dec 13, 2023

@acuarica yes I did check this. We should be good to go.

@acuarica acuarica merged commit ff002d8 into main Dec 13, 2023
5 checks passed
@acuarica acuarica deleted the 91-hedera-sourcify-search-views-have-different-behavior branch December 13, 2023 16:57
This was referenced Apr 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

@svienot svienot svienot approved these changes

@quiet-node quiet-node Awaiting requested review from quiet-node quiet-node is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@Sheng-Long Sheng-Long Awaiting requested review from Sheng-Long Sheng-Long is a code owner automatically assigned from hashgraph/dev-experience

@ericleponner ericleponner Awaiting requested review from ericleponner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hedera Sourcify search views have different behavior
3 participants
@acuarica @svienot @Nana-EC