Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: topic subscription error handling #1907

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

rokn
Copy link
Contributor

@rokn rokn commented Sep 26, 2023

Description:
Add keep alive ping to the mirror node connection so we can notify on connection drops.

Related issue(s):

Fixes #1890

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@petreze petreze merged commit 3033254 into develop Sep 26, 2023
9 of 10 checks passed
@petreze petreze deleted the fix/topic-subsciption-errors branch September 26, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error handling on topic message subscriptions
2 participants