Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add otel collector sidecar container #134

Merged
merged 11 commits into from
Jul 5, 2023

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Jun 29, 2023

Description

This pull request updates helm chart for network node with the following capabilities:

  • otel-collector side car container

Related Issues

@leninmehedy leninmehedy linked an issue Jun 29, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Unit Test Results

35 tests  ±0   32 ✔️ ±0   26s ⏱️ ±0s
  8 suites ±0     3 💤 ±0 
  8 files   ±0     0 ±0 

Results for commit 5907167. ± Comparison against base commit 76055e0.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #134 (5907167) into main (76055e0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #134   +/-   ##
=========================================
  Coverage     51.79%   51.79%           
  Complexity      139      139           
=========================================
  Files            36       36           
  Lines           668      668           
  Branches         73       73           
=========================================
  Hits            346      346           
  Misses          290      290           
  Partials         32       32           

Impacted file tree graph

@leninmehedy leninmehedy changed the title feat: statefulset network-node with sidecar otel collector feat: otel collector side car Jun 30, 2023
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy leninmehedy changed the title feat: otel collector side car feat: add otel collector sidecar container Jun 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leninmehedy leninmehedy marked this pull request as ready for review June 30, 2023 07:32
@leninmehedy leninmehedy marked this pull request as draft June 30, 2023 07:32
@jeromy-cannon jeromy-cannon self-requested a review June 30, 2023 16:05
@leninmehedy leninmehedy marked this pull request as ready for review June 30, 2023 19:48
@leninmehedy
Copy link
Member Author

leninmehedy commented Jul 5, 2023

merging it for now with the Otel collector container sidecar running.

I can see other containers are crashing. Also I am unable to test if OTel collector is working since the root container shutting down (it doesn't run any program currently).

Screenshot 2023-07-05 at 9 24 38 AM

I'll create separate PR with fixes as required.

@leninmehedy leninmehedy merged commit 09de701 into main Jul 5, 2023
@leninmehedy leninmehedy deleted the 113-helm-chart-open-telemetry branch July 5, 2023 00:13
swirlds-automation added a commit that referenced this pull request Jul 5, 2023
## [0.2.0](v0.1.2...v0.2.0) (2023-07-05)

### Features

* add github templates ([#124](#124)) ([7990742](7990742))
* add otel collector sidecar container ([#134](#134)) ([09de701](09de701))
* add semantic-release based CI pipelines ([#136](#136)) ([76055e0](76055e0))
* add SLF4J logging to fullstack-helm-client module ([#137](#137)) ([4115810](4115810))
* boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca))
* implement mirror.py container support (via side car) ([#135](#135)) ([c8ea9e2](c8ea9e2))
* publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d))
* relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))

### Bug Fixes

* update configurations for mirror uploader sidecars ([#138](#138)) ([118662f](118662f))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Network Node]: Implement Open Telemetry container support
3 participants