Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: boilerplate helm chart #121

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

deepak-swirlds
Copy link
Contributor

@deepak-swirlds deepak-swirlds commented Jun 27, 2023

Adding first draft of a helm chart which deploys hedera network according to configuration specified in the values.yaml
closes #110
It can create:

  • multiple hedera nodes, each will different configuration
    A hedera node is deployed as a single statefulset with a single replica
  • A service to expose each hedera node 50211 port
  • a haproxy, an envoy proxy, a json rpc relay for each hedera node

Signed-off-by: Deepak Mishra <[email protected]>
@deepak-swirlds deepak-swirlds changed the title boilerplate helm chart feat: boilerplate helm chart Jun 27, 2023
@github-actions
Copy link

Unit Test Results

35 tests  ±0   32 ✔️ ±0   29s ⏱️ ±0s
  8 suites ±0     3 💤 ±0 
  8 files   ±0     0 ±0 

Results for commit 9db2667. ± Comparison against base commit a930f62.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a930f62) 51.79% compared to head (9db2667) 51.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #121   +/-   ##
=========================================
  Coverage     51.79%   51.79%           
  Complexity      139      139           
=========================================
  Files            36       36           
  Lines           668      668           
  Branches         73       73           
=========================================
  Hits            346      346           
  Misses          290      290           
  Partials         32       32           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

data:
# add your secrets here
# Note: Kubernetes secrets should be base64 encoded
secret1: "c2VjcmV0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like it would be better to use github secrets, even if this is an example and not a real secret.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually just generate these pseudo-randomly via Helm and then we can retrieve the secret from the K8S cluster.

Copy link
Member

@nathanklick nathanklick Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, this is just a boilerplate/template. @jeromy-cannon Your point is valid we should never commit actual secrets to a repository, but for expediency we should go ahead and treat this as an intentionally committed toss away secret.

Changing this to a generated secret is outside the scope of this issue/PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes there are just for completeness sake, we should never checkin real secrets

data:
# add your secrets here
# Note: Kubernetes secrets should be base64 encoded
secret1: "c2VjcmV0"
Copy link
Member

@nathanklick nathanklick Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, this is just a boilerplate/template. @jeromy-cannon Your point is valid we should never commit actual secrets to a repository, but for expediency we should go ahead and treat this as an intentionally committed toss away secret.

Changing this to a generated secret is outside the scope of this issue/PR.

Comment on lines +3 to +22
nodes:
node-1:
# TODO: Configuration like address ( and similar ), can be autogenerated by helm, do we need to think about this ?
address: 0.0.1
cpu: 1
memory: 1GB
latency: 10ms
bandwidth: 1 Mbps
node-2:
address: 0.0.2
cpu: 1
memory: 1GB
latency: 10ms
bandwidth: 2 Mbps
node-3:
address: 0.0.3
cpu: 1
memory: 1GB
latency: 10ms
bandwidth: 3 Mbps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a list construct, but changing this is outside the scope of this issue/PR.

@deepak-swirlds deepak-swirlds merged commit 70c66ca into main Jun 28, 2023
@deepak-swirlds deepak-swirlds deleted the 110-setup-helm-chart-boilerplate branch June 28, 2023 04:29
nathanklick pushed a commit that referenced this pull request Jun 28, 2023
## [0.2.0](v0.1.2...v0.2.0) (2023-06-28)

### Features

* add github templates ([#124](#124)) ([7990742](7990742))
* boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca))
* publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d))
* relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))
github-actions bot pushed a commit that referenced this pull request Jun 29, 2023
## [0.2.0-alpha.1](v0.1.2...v0.2.0-alpha.1) (2023-06-29)

### Features

* add github templates ([#124](#124)) ([7990742](7990742))
* boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca))
* publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d))
* relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))
@hashgraph hashgraph deleted a comment from github-actions bot Jun 29, 2023
swirlds-automation added a commit that referenced this pull request Jul 5, 2023
## [0.2.0](v0.1.2...v0.2.0) (2023-07-05)

### Features

* add github templates ([#124](#124)) ([7990742](7990742))
* add otel collector sidecar container ([#134](#134)) ([09de701](09de701))
* add semantic-release based CI pipelines ([#136](#136)) ([76055e0](76055e0))
* add SLF4J logging to fullstack-helm-client module ([#137](#137)) ([4115810](4115810))
* boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca))
* implement mirror.py container support (via side car) ([#135](#135)) ([c8ea9e2](c8ea9e2))
* publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d))
* relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))

### Bug Fixes

* update configurations for mirror uploader sidecars ([#138](#138)) ([118662f](118662f))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IRS: Setup Helm Chart Boilerplate
4 participants