-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: boilerplate helm chart #121
Conversation
Signed-off-by: Deepak Mishra <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=========================================
Coverage 51.79% 51.79%
Complexity 139 139
=========================================
Files 36 36
Lines 668 668
Branches 73 73
=========================================
Hits 346 346
Misses 290 290
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
data: | ||
# add your secrets here | ||
# Note: Kubernetes secrets should be base64 encoded | ||
secret1: "c2VjcmV0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like it would be better to use github secrets, even if this is an example and not a real secret.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually just generate these pseudo-randomly via Helm and then we can retrieve the secret from the K8S cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a side note, this is just a boilerplate/template. @jeromy-cannon Your point is valid we should never commit actual secrets to a repository, but for expediency we should go ahead and treat this as an intentionally committed toss away secret.
Changing this to a generated secret is outside the scope of this issue/PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes there are just for completeness sake, we should never checkin real secrets
data: | ||
# add your secrets here | ||
# Note: Kubernetes secrets should be base64 encoded | ||
secret1: "c2VjcmV0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a side note, this is just a boilerplate/template. @jeromy-cannon Your point is valid we should never commit actual secrets to a repository, but for expediency we should go ahead and treat this as an intentionally committed toss away secret.
Changing this to a generated secret is outside the scope of this issue/PR.
nodes: | ||
node-1: | ||
# TODO: Configuration like address ( and similar ), can be autogenerated by helm, do we need to think about this ? | ||
address: 0.0.1 | ||
cpu: 1 | ||
memory: 1GB | ||
latency: 10ms | ||
bandwidth: 1 Mbps | ||
node-2: | ||
address: 0.0.2 | ||
cpu: 1 | ||
memory: 1GB | ||
latency: 10ms | ||
bandwidth: 2 Mbps | ||
node-3: | ||
address: 0.0.3 | ||
cpu: 1 | ||
memory: 1GB | ||
latency: 10ms | ||
bandwidth: 3 Mbps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a list construct, but changing this is outside the scope of this issue/PR.
## [0.2.0](v0.1.2...v0.2.0) (2023-06-28) ### Features * add github templates ([#124](#124)) ([7990742](7990742)) * boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca)) * publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d)) * relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))
## [0.2.0-alpha.1](v0.1.2...v0.2.0-alpha.1) (2023-06-29) ### Features * add github templates ([#124](#124)) ([7990742](7990742)) * boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca)) * publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d)) * relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))
## [0.2.0](v0.1.2...v0.2.0) (2023-07-05) ### Features * add github templates ([#124](#124)) ([7990742](7990742)) * add otel collector sidecar container ([#134](#134)) ([09de701](09de701)) * add semantic-release based CI pipelines ([#136](#136)) ([76055e0](76055e0)) * add SLF4J logging to fullstack-helm-client module ([#137](#137)) ([4115810](4115810)) * boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca)) * implement mirror.py container support (via side car) ([#135](#135)) ([c8ea9e2](c8ea9e2)) * publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d)) * relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c)) ### Bug Fixes * update configurations for mirror uploader sidecars ([#138](#138)) ([118662f](118662f))
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Adding first draft of a helm chart which deploys hedera network according to configuration specified in the values.yaml
closes #110
It can create:
A hedera node is deployed as a single statefulset with a single replica