Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SLF4J logging to fullstack-helm-client module #137

Merged
merged 13 commits into from
Jul 5, 2023

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • Add SLF4J API and Log4j2 dependencies to the BOM project. Only require the SLF4J API in production code. Logging implementation should only be in unit test code.
  • Add appropriately leveled log statements where necessary.

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Unit Test Results

35 tests  ±0   32 ✔️ ±0   27s ⏱️ -1s
  8 suites ±0     3 💤 ±0 
  8 files   ±0     0 ±0 

Results for commit e027c16. ± Comparison against base commit 118662f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #137 (e027c16) into main (118662f) will increase coverage by 2.00%.
The diff coverage is 80.64%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #137      +/-   ##
============================================
+ Coverage     51.79%   53.80%   +2.00%     
- Complexity      139      140       +1     
============================================
  Files            36       36              
  Lines           668      723      +55     
  Branches         73       73              
============================================
+ Hits            346      389      +43     
- Misses          290      302      +12     
  Partials         32       32              
Impacted Files Coverage Δ
...fullstack/helm/client/execution/HelmExecution.java 60.16% <75.00%> (+6.22%) ⬆️
...ck/helm/client/execution/HelmExecutionBuilder.java 84.90% <100.00%> (+1.92%) ⬆️
...stack/helm/client/resource/HelmSoftwareLoader.java 83.33% <100.00%> (+6.86%) ⬆️

Impacted file tree graph

@jeromy-cannon jeromy-cannon requested a review from nathanklick July 5, 2023 16:21
@jeromy-cannon jeromy-cannon marked this pull request as ready for review July 5, 2023 16:22
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.6% 80.6% Coverage
0.0% 0.0% Duplication

@nathanklick nathanklick merged commit 4115810 into main Jul 5, 2023
@nathanklick nathanklick deleted the 00086-slf4j branch July 5, 2023 17:47
swirlds-automation added a commit that referenced this pull request Jul 5, 2023
## [0.2.0](v0.1.2...v0.2.0) (2023-07-05)

### Features

* add github templates ([#124](#124)) ([7990742](7990742))
* add otel collector sidecar container ([#134](#134)) ([09de701](09de701))
* add semantic-release based CI pipelines ([#136](#136)) ([76055e0](76055e0))
* add SLF4J logging to fullstack-helm-client module ([#137](#137)) ([4115810](4115810))
* boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca))
* implement mirror.py container support (via side car) ([#135](#135)) ([c8ea9e2](c8ea9e2))
* publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d))
* relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))

### Bug Fixes

* update configurations for mirror uploader sidecars ([#138](#138)) ([118662f](118662f))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Client: Add SLF4J logging support
3 participants