Add padding for WebGL support by padding buffer content #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a comment at the padding why we need it? |
|
Can confirm that this resolves the issue I was having with running egui with wgpu's WebGL backend 👍 Thanks @svents! |
Done |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: thanks for providing the egui backends! With Vulkan everything worked out of the box, but with WASM/WebGL I ran into the issue described here: #58
Since at least one other person had the same issue here, I thought that I might as well push my local fork. In addition to the padding that solves the WebGL issue, I also added size limits in a separate commit.