Added social auth... #405
Added social auth... #405
Conversation
…e, removed prod tokens(and changed them), enhanced settings structure
| @@ -206,6 +206,7 @@ def account_login(request, template_name='registration/login.html', | |||
| redirect_field_name: redirect_to, | |||
| 'site': current_site, | |||
| 'site_name': current_site.name, | |||
| 'messages': get_messages(request), | |||
There was a problem hiding this comment.
Why not use the messages context processor here? It's already enabled in the settings (
…o feature/volo-to-bower
Changing appearance of budget items in the legend (see description)
|
|
||
| ) | ||
|
|
||
| try: |
There was a problem hiding this comment.
I don't understand why you wrap all of these in a try/except.
There was a problem hiding this comment.
@ydaniv asked me to catch an import error there, in case some developers
don't have the file with the social media tokens & secret keys.
On Fri, Mar 7, 2014 at 8:08 AM, Paul Walsh [email protected] wrote:
In openbudgets/settings/init.py:
)
+SOCIAL_AUTH_PIPELINE = (
'social_auth.backends.pipeline.social.social_auth_user','openbudgets.apps.accounts.social_pipeline.associate_by_email', # only difference from default'social_auth.backends.pipeline.user.get_username',# 'social_auth.backends.pipeline.user.create_user','openbudgets.apps.accounts.social_pipeline.create_user',#custom pipeline'social_auth.backends.pipeline.social.associate_user','social_auth.backends.pipeline.social.load_extra_data','social_auth.backends.pipeline.user.update_user_details'
- )
+
+try:I don't understand why you wrap all of these in a try/except.
Reply to this email directly or view it on GitHubhttps://github.com//pull/405/files#r10374253
.
There was a problem hiding this comment.
So, shouldn't this stuff be in the said file then, and not here at all? Seeing as it all strictly depends on that file? Which file are you referring to?
There was a problem hiding this comment.
if it these are project's defaults and it makes sense to have them here then they should be left here, if not then they can be removed and we only need import social_config in a try-catch clause.
|
Hi @BeOleg there is no need for us to hold on merging this because of the design issues. I'd rather merge it so it is available when we do the next design round. However, there are some things that need to be done before considering merging it with the codebase:
|
| <form method="POST" action="{% url "socialauth_disconnect_individual" provider account.id %}" | ||
| class="social-revoke-form"> | ||
| {% csrf_token %} | ||
| <input type="submit" class="social-revoke-control" value="-"> {{ provider }} |
There was a problem hiding this comment.
@BeOleg <input> is a non-content element. Perhaps it would be better to replace it with a <button> tag and put the {{ provider }} as its content?
There was a problem hiding this comment.
The idea is to have a - sign side by side with the network's name, to symbolize the revoke of the credentials of this certain network.
Same thing can be achieved by placing {{provider}} in the 'value' attribute of the input element, a button element will work as well, as long as it's has a type='submit' attribute, since I only accept POST request to the credentials revoke resource to prevent XSS.
Wanted to enhance the design of this entire thing, but frankly could not figure out which less file applies to this section :(
There was a problem hiding this comment.
Don't worry abut UI behaviour, until we do new UI work with Ran.
forced dependency on old versions of libraries.
…velop Conflicts: requirements.txt
… social_auth Conflicts: requirements.txt
2 current issues: