Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social auth layer #107

Open
pwalsh opened this issue May 3, 2013 · 6 comments
Open

Social auth layer #107

pwalsh opened this issue May 3, 2013 · 6 comments
Assignees
Milestone

Comments

@pwalsh
Copy link
Member

pwalsh commented May 3, 2013

We want to add the ability to login via Facebook, Twitter, and Google+ to Open Muni.

This social auth layer must be completely transparent and integrated with the "native" auth that is already in place.

For all social auth, we want to access the user email (so the oauth scope needs to reflect that), and also First Name + Last Name if available on the service.

Services that allow us to post data via the user (fb and twitter), must get this permission too, as part of the auth process.

Any implementation must work with existing users, not just new users. We must support use cases where:

  • A new user can register natively, fb, twitter or google+
  • an existing user can add fb, twitter, google+ auth (whatever s/he does not have)
  • an existing user can remove fb/twitter/google+ auth
  • a user that registered only via fb/twitter/google+, would still be able to disconnect from these services, and log in natively (means you must give each user a password).

We'd like this implemented with django-social-auth:

If you have a suggestion you think is better, please make a case for it here, in the comments.

And, specifically on the issue of native auth combined with a number of social auths, you can refer to this thread in the django-social-auth mailing list:

https://groups.google.com/forum/?fromgroups#!topic/django-social-auth/YvijRk3QhSY

If any of the requirements are unclear, please ask @pwalsh or @ydaniv before starting to code.

Here are our docs, on accounts in Open Muni, as they exist currently:

http://open-budget.readthedocs.org/en/latest/guide/features/accounts.html

@shaib
Copy link

shaib commented Jul 20, 2013

I'm starting to work on this.

@ghost ghost assigned shaib Jul 22, 2013
@pwalsh
Copy link
Member Author

pwalsh commented Aug 5, 2013

Hey @shaib how are things going on this?

@pwalsh
Copy link
Member Author

pwalsh commented Oct 27, 2013

@shaib made some progress on this feature, but various parts of the project API changed during that time. Whoever picks up this task could look at Shai's work here: https://github.com/shaib/openbudgets/tree/hackathon and pick up from there.

@BeOleg
Copy link

BeOleg commented Feb 10, 2014

Done, now only missing a nice design, and a fix to the account_details view that sometimes only gets updated after another full page refresh after disconnecting from one of the networks or adding another one

#405

@ransegall
Copy link

We're currently working on a new design for the whole project, so we'll wait before we implement the design for this.

@BeOleg
Copy link

BeOleg commented Mar 7, 2014

Still, in order for it to be functional, it needs a more reasonable design, we should probably close this issue, and open another issue for the design of the social auth buttons, and assign it to me, once it'll be done, we can finally merge it.

@pwalsh pwalsh modified the milestones: Future, API Server Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants