Don't count phase==True toward genotypes
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsdewitt
changed the title
phase=True toward genotypesphase==True toward genotypes
mrvollger
reviewed
Jun 21, 2022
| @@ -231,8 +231,6 @@ def targets(args): | |||
| def spectra(args): | |||
| """subroutine for spectra subcommand.""" | |||
|
|
|||
| # NOTE: vcf must be instantiated with gts012=False (the default) due to cyvcf2 | |||
| # num_unknown property bug https://github.com/brentp/cyvcf2/issues/236 | |||
There was a problem hiding this comment.
I would vote for leaving this or setting the minimum version of cyvcf2 to be a version that includes the fix. but you can ignore if you disagree.
There was a problem hiding this comment.
Good call—I've added cyvcf2 version enforcement to setup.py
mrvollger
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the latest incarnation of #30