Fix: Restore buffer local settings outside reviewer #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scripts for running go tests and git tests
feat: Automatically open fold under cursor, redraw screen with cursor at center
* fix: use body with /mr/draft_notes/publish endpoint * docs: notify about successfully building server
Fixed some bad warnings when the branch was out of date or ahead of the remote tracking branch. --------- Co-authored-by: Jakub F. Bortlík <[email protected]>
Fix: Show draft replies in the correct tree
Fix: Use correct name for emoji
fix: fixes wrong GET to gitlab when the URL includes namespacing. Fixes harrisoncramer#413.
|
@briandipalma in August you reported the issue that I'm fixing in this PR, could you please try out this branch and let us know if it fixes the issue for you? |
jakubbortlik
commented
Dec 13, 2024
|
I've just gone on holidays so I doubt I'll get the time to test this until after Christmas, I'll take a look in January. |
jakubbortlik
force-pushed
the
fix-buffer-local-settings-outside-reviewer
branch
from
e5a5962 to
03bb696
Compare
harrisoncramer
force-pushed
the
develop
branch
2 times, most recently
from
3b57759 to
3b396a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue originally reported in #347. After a closer inspection it is a gitlab.nvim bug, as currently we are removing keymaps and resetting 'modifiable' only for the currently active buffer, but not for other buffers previously shown by Diffview.
This PR fixes the issue by setting and deleting keymaps when entering any window that contains a Diffview buffer or when switching to a Diffview buffer without changing the window (i.e., cursor is already in the reviewer).
Edit: Apart from this fix, this PR also limits refreshing diagnostics to when the
revieweris entered, as opposed to the previous way when diagnostics were refreshed every time the reviewer buffer was changed. This speeds up the file switching significantly (although this is practically only noticeable when holding down<tab>to cycle between the diffs quickly which I don't think is something people do frequently 😄).