Fix: Show draft replies in the correct tree #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubbortlik
commented
Oct 12, 2024
jakubbortlik
force-pushed
the
fix-draft-replies-to-comments-shown-as-draft-notes
branch
from
7b8ca98 to
5a62063
Compare
| local unlinked_draft_notes = List.new(state.DRAFT_NOTES):filter(function(note) | ||
| return not draft_notes.has_position(note) | ||
| local inline_draft_notes, unlinked_draft_notes = List.new(state.DRAFT_NOTES):partition(function(note) | ||
| if note.discussion_id == "" then |
There was a problem hiding this comment.
Small thing but since this is an early return, it's clearer in my opinion if you remove the else block. Meaning:
if some_cond then
return some_result
end
-- Do other work
There was a problem hiding this comment.
Oh, sure. It's indeed clearer. Fixed.
harrisoncramer
added a commit
that referenced
this pull request
Oct 13, 2024
fix: Error messages and run all tests (#381) feat: Automatically open fold under cursor (#380) fix: Discussion ID is not required (#383) chore: Add more emojis (#384) fix: Publish all drafts (#391) fix: Make discussion tree buffers no-modifiable (#394) fix: Incorrect warning about commits (#395) fix: Show draft replies in the correct tree (#396) fix: Cannot choose merge requests (#398) --------- Co-authored-by: George Kontridze <[email protected]> Co-authored-by: Jakub F. Bortlík <[email protected]>
jakubbortlik
deleted the
fix-draft-replies-to-comments-shown-as-draft-notes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392.