Can't specify specific resource type permissions for bulk export #3376

oliviayou · 2022-02-10T19:00:58Z

When exporting data that should only belong to a specific group of resources the user is permitted to export, data from other groups is returned. This has been corrected.
New tests
Add changelog

hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/interceptor/auth/RuleBulkExportImpl.java

codecov · 2022-02-10T20:11:27Z

Codecov Report

❗ No coverage uploaded for pull request base (rel_5_7@3531d9b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e12b93b differs from pull request most recent head 79d1f25. Consider uploading reports for the commit 79d1f25 to get more accurate results

@@            Coverage Diff             @@
##             rel_5_7    #3376   +/-   ##
==========================================
  Coverage           ?   82.82%           
  Complexity         ?    20499           
==========================================
  Files              ?     1371           
  Lines              ?    73639           
  Branches           ?    11069           
==========================================
  Hits               ?    60993           
  Misses             ?     8395           
  Partials           ?     4251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3531d9b...79d1f25. Read the comment docs.

* fix handling of common search parameters * Revert "fix handling of common search parameters" This reverts commit 89c45ee. * Fix implementation, add test (#3378) * Fix implementation, add test * Tighten test * Rip out dead modules * Add changelog * Jr 20220210 handle common search params in contained searches (#3377) * fix handling of common search parameters * add support for reference search parameters with multiple paths * Issue 3357 * Version bump * Fixed null pointer exception for re-loading subscription on cdr restart and when there's no partition id in the request, and added tests * added changelogs for this fix * Fix broken changelog file * Can't specify specific resource type permissions for bulk export (#3376) * deny user from exporting without perms * add unit tests * add changelog Co-authored-by: olivia-you <[email protected]> * Make migration donothing as it was added in error * Remove ehcache * Add version.yaml: * Add to sources/javadocs for dist * Fix typo * fix up pom * wip test removing checkstyle plugin from deployable pom * remove test pom changes, instead just dont deploy to sonatype * typo * Remove ehcache Co-authored-by: Jason Roberts <[email protected]> Co-authored-by: JasonRoberts-smile <[email protected]> Co-authored-by: Mark Iantorno <[email protected]> Co-authored-by: Steven Li <[email protected]> Co-authored-by: Olivia You <[email protected]> Co-authored-by: olivia-you <[email protected]>

* fix handling of common search parameters * Revert "fix handling of common search parameters" This reverts commit 89c45ee. * Fix implementation, add test (#3378) * Fix implementation, add test * Tighten test * Rip out dead modules * Add changelog * Jr 20220210 handle common search params in contained searches (#3377) * fix handling of common search parameters * add support for reference search parameters with multiple paths * Issue 3357 * Version bump * Fixed null pointer exception for re-loading subscription on cdr restart and when there's no partition id in the request, and added tests * added changelogs for this fix * Fix broken changelog file * Can't specify specific resource type permissions for bulk export (#3376) * deny user from exporting without perms * add unit tests * add changelog Co-authored-by: olivia-you <[email protected]> * Make migration donothing as it was added in error * Remove ehcache * Add version.yaml: * Add to sources/javadocs for dist * Fix typo * fix up pom * wip test removing checkstyle plugin from deployable pom * remove test pom changes, instead just dont deploy to sonatype * typo * Version bump * Add implementation, testing, and changelog * Add backport info, make aware of 6_0_0 * add jira ref * Fix test * Add versionenum * Remove dups * Remove unnecessary stuff Co-authored-by: Jason Roberts <[email protected]> Co-authored-by: JasonRoberts-smile <[email protected]> Co-authored-by: Mark Iantorno <[email protected]> Co-authored-by: Steven Li <[email protected]> Co-authored-by: Olivia You <[email protected]> Co-authored-by: olivia-you <[email protected]>

* fix handling of common search parameters * Revert "fix handling of common search parameters" This reverts commit 89c45ee. * Fix implementation, add test (#3378) * Fix implementation, add test * Tighten test * Rip out dead modules * Add changelog * Jr 20220210 handle common search params in contained searches (#3377) * fix handling of common search parameters * add support for reference search parameters with multiple paths * Issue 3357 * Version bump * Fixed null pointer exception for re-loading subscription on cdr restart and when there's no partition id in the request, and added tests * added changelogs for this fix * Fix broken changelog file * Can't specify specific resource type permissions for bulk export (#3376) * deny user from exporting without perms * add unit tests * add changelog Co-authored-by: olivia-you <[email protected]> * Make migration donothing as it was added in error * Remove ehcache * Add version.yaml: * Add to sources/javadocs for dist * Fix typo * fix up pom * wip test removing checkstyle plugin from deployable pom * remove test pom changes, instead just dont deploy to sonatype * typo * Version bump * Add implementation, testing, and changelog * Add backport info, make aware of 6_0_0 * add jira ref * Fix test * Add versionenum * Bump dep for spring, add changelog, add versionenum, add changelog folder * Actually do the version bump * remove doubleimport Co-authored-by: Jason Roberts <[email protected]> Co-authored-by: JasonRoberts-smile <[email protected]> Co-authored-by: Mark Iantorno <[email protected]> Co-authored-by: Steven Li <[email protected]> Co-authored-by: Olivia You <[email protected]> Co-authored-by: olivia-you <[email protected]>

* fix handling of common search parameters * Revert "fix handling of common search parameters" This reverts commit 89c45ee. * Fix implementation, add test (hapifhir#3378) * Fix implementation, add test * Tighten test * Rip out dead modules * Add changelog * Jr 20220210 handle common search params in contained searches (hapifhir#3377) * fix handling of common search parameters * add support for reference search parameters with multiple paths * Issue 3357 * Version bump * Fixed null pointer exception for re-loading subscription on cdr restart and when there's no partition id in the request, and added tests * added changelogs for this fix * Fix broken changelog file * Can't specify specific resource type permissions for bulk export (hapifhir#3376) * deny user from exporting without perms * add unit tests * add changelog Co-authored-by: olivia-you <[email protected]> * Make migration donothing as it was added in error * Remove ehcache * Add version.yaml: * Add to sources/javadocs for dist * Fix typo * fix up pom * wip test removing checkstyle plugin from deployable pom * remove test pom changes, instead just dont deploy to sonatype * typo * Version bump * Add implementation, testing, and changelog * Add backport info, make aware of 6_0_0 * add jira ref * Fix test * Add versionenum * Bump dep for spring, add changelog, add versionenum, add changelog folder * Actually do the version bump * remove doubleimport Co-authored-by: Jason Roberts <[email protected]> Co-authored-by: JasonRoberts-smile <[email protected]> Co-authored-by: Mark Iantorno <[email protected]> Co-authored-by: Steven Li <[email protected]> Co-authored-by: Olivia You <[email protected]> Co-authored-by: olivia-you <[email protected]>

* fix handling of common search parameters * Revert "fix handling of common search parameters" This reverts commit 89c45ee. * Fix implementation, add test (#3378) * Fix implementation, add test * Tighten test * Rip out dead modules * Add changelog * Jr 20220210 handle common search params in contained searches (#3377) * fix handling of common search parameters * add support for reference search parameters with multiple paths * Issue 3357 * Version bump * Fixed null pointer exception for re-loading subscription on cdr restart and when there's no partition id in the request, and added tests * added changelogs for this fix * Fix broken changelog file * Can't specify specific resource type permissions for bulk export (#3376) * deny user from exporting without perms * add unit tests * add changelog Co-authored-by: olivia-you <[email protected]> * Make migration donothing as it was added in error * Remove ehcache * Add version.yaml: * Add to sources/javadocs for dist * Fix typo * fix up pom * wip test removing checkstyle plugin from deployable pom * remove test pom changes, instead just dont deploy to sonatype * typo * Version bump * Add implementation, testing, and changelog * Add backport info, make aware of 6_0_0 * add jira ref * Fix test * Add versionenum * Bump dep for spring, add changelog, add versionenum, add changelog folder * Actually do the version bump * 3654 postgres lobs (#3656) * Implementation, test, changelog * Modify changelog * Fix changelog * Add upgrade.md file * Modify to yaml changes * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_7_3/3654-lob-problems.yaml Co-authored-by: Ken Stevens <[email protected]> * tidy * more work Co-authored-by: Ken Stevens <[email protected]> * Fix bad yaml indent * Version bump * Back out the reindex changes introduced in 5.7.3 * update changelog * version bump * added fix for subscription in default partition when default partition's id is null * added changelog * Add version info and changelog folder * adding release pipeline yml file fo azure * Fix parameter count limitation on MSSQL/Oracle large transactions (#3075) * Fix parameter count limitation on MSSQL/Oracle large transactions * Changelog fix * Move changelog * Force a change to trigger CI * Test refactoring * Backport oracle fix * Fix backport * upping version to 5.7.5 for release * add versionenum * Updating version to: 5.7.6 post release. * Add query-chunk-aware code * Add new folder * Fix up versionenum * Remove imports Co-authored-by: Jason Roberts <[email protected]> Co-authored-by: JasonRoberts-smile <[email protected]> Co-authored-by: Mark Iantorno <[email protected]> Co-authored-by: Steven Li <[email protected]> Co-authored-by: Olivia You <[email protected]> Co-authored-by: olivia-you <[email protected]> Co-authored-by: Ken Stevens <[email protected]> Co-authored-by: Long Ma <[email protected]> Co-authored-by: James Agnew <[email protected]>

deny user from exporting without perms

8aab410

fil512 requested changes Feb 10, 2022

View reviewed changes

hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/interceptor/auth/RuleBulkExportImpl.java Show resolved Hide resolved

add unit tests

e12b93b

tadgh requested a review from fil512 February 14, 2022 21:20

add changelog

79d1f25

fil512 approved these changes Feb 14, 2022

View reviewed changes

tadgh merged commit a918e12 into rel_5_7 Feb 14, 2022

tadgh deleted the 2786-bug-specify-specific-resource-type-permissions-for-bulk-export branch February 14, 2022 21:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't specify specific resource type permissions for bulk export #3376

Can't specify specific resource type permissions for bulk export #3376

oliviayou commented Feb 10, 2022 •

edited

Loading

codecov bot commented Feb 10, 2022 •

edited

Loading

Can't specify specific resource type permissions for bulk export #3376

Can't specify specific resource type permissions for bulk export #3376

Conversation

oliviayou commented Feb 10, 2022 • edited Loading

codecov bot commented Feb 10, 2022 • edited Loading

Codecov Report

oliviayou commented Feb 10, 2022 •

edited

Loading

codecov bot commented Feb 10, 2022 •

edited

Loading