Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter count limitation on MSSQL/Oracle large transactions #3075

Merged
merged 7 commits into from
Feb 20, 2022

Conversation

jamesagnew
Copy link
Collaborator

Fix #3065

@jenspetervester
Copy link

Any plans on including this in a release?

Copy link
Collaborator

@oliviayou oliviayou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!

@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #3075 (9f4df7a) into master (0c5d868) will increase coverage by 0.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3075   +/-   ##
=========================================
  Coverage     82.96%   82.96%           
- Complexity    20674    20681    +7     
=========================================
  Files          1392     1392           
  Lines         74243    74267   +24     
  Branches      11136    11138    +2     
=========================================
+ Hits          61592    61617   +25     
+ Misses         8366     8365    -1     
  Partials       4285     4285           
Impacted Files Coverage Δ
...ava/ca/uhn/fhir/jpa/dao/index/IdHelperService.java 77.70% <81.81%> (-0.53%) ⬇️
...n/fhir/jpa/packages/PackageInstallOutcomeJson.java 100.00% <100.00%> (ø)
...base/src/main/java/ca/uhn/fhir/util/DateUtils.java 88.17% <0.00%> (-0.13%) ⬇️
...ava/ca/uhn/fhir/jpa/search/builder/QueryStack.java 90.20% <0.00%> (-0.07%) ⬇️
...ain/java/ca/uhn/fhir/jpa/config/HapiJpaConfig.java 87.50% <0.00%> (ø)
...ava/ca/uhn/fhir/jpa/dao/search/LastNOperation.java 100.00% <0.00%> (ø)
...a/ca/uhn/fhir/jpa/dao/search/LastNAggregation.java 100.00% <0.00%> (ø)
...ca/uhn/fhir/jpa/config/FhirContextDstu2Config.java 100.00% <0.00%> (ø)
...ca/uhn/fhir/jpa/config/r4/FhirContextR4Config.java 100.00% <0.00%> (ø)
...ca/uhn/fhir/jpa/config/r5/FhirContextR5Config.java 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5d868...9f4df7a. Read the comment docs.

@jamesagnew jamesagnew merged commit 1e2e177 into master Feb 20, 2022
@jamesagnew jamesagnew deleted the ja_20211014_3065_transactions_with_many_forcedids branch February 20, 2022 16:52
michaelabuckley added a commit that referenced this pull request Feb 22, 2022
…oken-search-index

* commit 'fcada390442ee3ada2245f49d62c08cde5212cd7':
  add online deferred invalidation keyword for oracle (#3409)
  GraphQL Introspection Support (#3348)
  Fix parameter count limitation on MSSQL/Oracle large transactions (#3075)
  3400 bulk export rules incorrectly applied to group and patient exports (#3403)
  Use integers for date ordinals (#3346)
  Add license files
  Rel 5 7 mergeback (#3401)
  encode narratives of contained resources (#3402)
  remove hapi jpa spring config hierarchy (#3390)

# Conflicts:
#	hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4LuceneDisabledStandardQueries.java
tadgh pushed a commit that referenced this pull request Jul 7, 2022
)

* Fix parameter count limitation on MSSQL/Oracle large transactions

* Changelog fix

* Move changelog

* Force a change to trigger CI

* Test refactoring
tadgh added a commit that referenced this pull request Jul 12, 2022
* fix handling of common search parameters

* Revert "fix handling of common search parameters"

This reverts commit 89c45ee.

* Fix implementation, add test (#3378)

* Fix implementation, add test

* Tighten test

* Rip out dead modules

* Add changelog

* Jr 20220210 handle common search params in contained searches (#3377)

* fix handling of common search parameters

* add support for reference search parameters with multiple paths

* Issue 3357

* Version bump

* Fixed null pointer exception for re-loading subscription on cdr restart and when there's no partition id in the request, and added tests

* added changelogs for this fix

* Fix broken changelog file

* Can't specify specific resource type permissions for bulk export (#3376)

* deny user from exporting without perms

* add unit tests

* add changelog

Co-authored-by: olivia-you <[email protected]>

* Make migration donothing as it was added in error

* Remove ehcache

* Add version.yaml:

* Add to sources/javadocs for dist

* Fix typo

* fix up pom

* wip test removing checkstyle plugin from deployable pom

* remove test pom changes, instead just dont deploy to sonatype

* typo

* Version bump

* Add implementation, testing, and changelog

* Add backport info, make aware of 6_0_0

* add jira ref

* Fix test

* Add versionenum

* Bump dep for spring, add changelog, add versionenum, add changelog folder

* Actually do the version bump

* 3654 postgres lobs (#3656)

* Implementation, test, changelog

* Modify changelog

* Fix changelog

* Add upgrade.md file

* Modify to yaml changes

* Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_7_3/3654-lob-problems.yaml

Co-authored-by: Ken Stevens <[email protected]>

* tidy

* more work

Co-authored-by: Ken Stevens <[email protected]>

* Fix bad yaml indent

* Version bump

* Back out the reindex changes introduced in 5.7.3

* update changelog

* version bump

* added fix for subscription in default partition when default partition's id is null

* added changelog

* Add version info and changelog folder

* adding release pipeline yml file fo azure

* Fix parameter count limitation on MSSQL/Oracle large transactions (#3075)

* Fix parameter count limitation on MSSQL/Oracle large transactions

* Changelog fix

* Move changelog

* Force a change to trigger CI

* Test refactoring

* Backport oracle fix

* Fix backport

* upping version to 5.7.5 for release

* add versionenum

* Updating version to: 5.7.6 post release.

* Add query-chunk-aware code

* Add new folder

* Fix up versionenum

* Remove imports

Co-authored-by: Jason Roberts <[email protected]>
Co-authored-by: JasonRoberts-smile <[email protected]>
Co-authored-by: Mark Iantorno <[email protected]>
Co-authored-by: Steven Li <[email protected]>
Co-authored-by: Olivia You <[email protected]>
Co-authored-by: olivia-you <[email protected]>
Co-authored-by: Ken Stevens <[email protected]>
Co-authored-by: Long Ma <[email protected]>
Co-authored-by: James Agnew <[email protected]>
Qingyixia pushed a commit that referenced this pull request Jul 22, 2022
* fix handling of common search parameters

* Revert "fix handling of common search parameters"

This reverts commit 89c45ee.

* Fix implementation, add test (#3378)

* Fix implementation, add test

* Tighten test

* Rip out dead modules

* Add changelog

* Jr 20220210 handle common search params in contained searches (#3377)

* fix handling of common search parameters

* add support for reference search parameters with multiple paths

* Issue 3357

* Version bump

* Fixed null pointer exception for re-loading subscription on cdr restart and when there's no partition id in the request, and added tests

* added changelogs for this fix

* Fix broken changelog file

* Can't specify specific resource type permissions for bulk export (#3376)

* deny user from exporting without perms

* add unit tests

* add changelog

Co-authored-by: olivia-you <[email protected]>

* Make migration donothing as it was added in error

* Remove ehcache

* Add version.yaml:

* Add to sources/javadocs for dist

* Fix typo

* fix up pom

* wip test removing checkstyle plugin from deployable pom

* remove test pom changes, instead just dont deploy to sonatype

* typo

* Version bump

* Add implementation, testing, and changelog

* Add backport info, make aware of 6_0_0

* add jira ref

* Fix test

* Add versionenum

* Bump dep for spring, add changelog, add versionenum, add changelog folder

* Actually do the version bump

* 3654 postgres lobs (#3656)

* Implementation, test, changelog

* Modify changelog

* Fix changelog

* Add upgrade.md file

* Modify to yaml changes

* Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_7_3/3654-lob-problems.yaml

Co-authored-by: Ken Stevens <[email protected]>

* tidy

* more work

Co-authored-by: Ken Stevens <[email protected]>

* Fix bad yaml indent

* Version bump

* Back out the reindex changes introduced in 5.7.3

* update changelog

* version bump

* added fix for subscription in default partition when default partition's id is null

* added changelog

* Add version info and changelog folder

* adding release pipeline yml file fo azure

* Fix parameter count limitation on MSSQL/Oracle large transactions (#3075)

* Fix parameter count limitation on MSSQL/Oracle large transactions

* Changelog fix

* Move changelog

* Force a change to trigger CI

* Test refactoring

* Backport oracle fix

* Fix backport

* upping version to 5.7.5 for release

* add versionenum

* Updating version to: 5.7.6 post release.

* Add query-chunk-aware code

* Add new folder

* Fix up versionenum

* Remove imports

Co-authored-by: Jason Roberts <[email protected]>
Co-authored-by: JasonRoberts-smile <[email protected]>
Co-authored-by: Mark Iantorno <[email protected]>
Co-authored-by: Steven Li <[email protected]>
Co-authored-by: Olivia You <[email protected]>
Co-authored-by: olivia-you <[email protected]>
Co-authored-by: Ken Stevens <[email protected]>
Co-authored-by: Long Ma <[email protected]>
Co-authored-by: James Agnew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large(ish) transaction bundles no longer work with SQL Server
3 participants