Expand export-validator to actually validate exported files
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
force-pushed
the
validator
branch
3 times, most recently
from
f49030c to
55c3193
Compare
It makes sense to have it in a separate job, so we get better feedback on what specifically failed, if the CI build does fail because of it. Also, I'm having trouble getting the actual 3MF validation to work on macOS, due to linking issues. I figure that running it on Linux is good enough for now.
|
I've extracted the 3MF validation into its own job, which means none of the required jobs are failing any more, which means this can actually be merged now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request can't be merged yet, because this validation fails (see #451). I'm going to address that next, and once I have,
export-validatorwill make sure there are not going to be regressions.Close #54