Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3MF export is partially broken because of triangle orientation #451

Closed
hannobraun opened this issue Apr 11, 2022 · 2 comments · Fixed by #484
Closed

3MF export is partially broken because of triangle orientation #451

hannobraun opened this issue Apr 11, 2022 · 2 comments · Fixed by #484
Assignees
Labels
topic: core Issues relating to core geometry, operations, algorithms topic: export Exporting to external file formats type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

Here's a 3D-printed version of the star model:
Picture of a black, star-shaped 3D print

The star-shaped hole is missing. This is most likely related to validation errors of the exported 3MF file:

Screenshot from a 3MF validation tool, showing a "bad triangle orientation" error

This is not surprising, as the kernel doesn't really have any concept of surface orientation. What wasn't clear so far, is that this affects the validity of exported 3MF files.

#339 is related, as both bugs have the same root cause. Another related (and now closed) issue is #173.

We should prevent such issues outright, by adding a 3MF validation step to the CI build (see #54).

Thanks to @dcompoze for reporting this on Matrix!

@hannobraun hannobraun added type: bug Something isn't working topic: export Exporting to external file formats labels Apr 11, 2022
@hannobraun
Copy link
Owner Author

An additional thought: As part of addressing this, it would probably be a good idea to revert #289, to make orientation bugs more visible.

@hannobraun
Copy link
Owner Author

I've started looking into this.

@hannobraun hannobraun self-assigned this Apr 13, 2022
@hannobraun hannobraun added the topic: core Issues relating to core geometry, operations, algorithms label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Issues relating to core geometry, operations, algorithms topic: export Exporting to external file formats type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant