Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump source and target compatibility to Java 1.8 #331

Closed
peterdemaeyer opened this issue Feb 21, 2021 · 1 comment · Fixed by #411
Closed

Bump source and target compatibility to Java 1.8 #331

peterdemaeyer opened this issue Feb 21, 2021 · 1 comment · Fixed by #411
Assignees
@tumbarumba

Comments

@peterdemaeyer
Copy link
Contributor

Hamcrest still supports Java 1.7 source and target compatibility.
Java 1.7 is out of support for years already, I suggest to bump to Java 1.8.
Once that is done, we can finally leverage some useful Java 1.8 features such as lambda expressions in the Hamcrest sources.
Due to quirks and differences with generic type arguments, the change is not as straightforward as it looks, but I'll take a stab at it nonetheless.
I'll prep a PR, but I'll need someone to remove the Java 1.7 compilation from the matrix job in the Travis build.
peterdemaeyer added a commit to peterdemaeyer/JavaHamcrest that referenced this issue Feb 21, 2021
@peterdemaeyer
hamcrest#331 Bumped source and target compatibility to Java 1.8
4ec227e
peterdemaeyer added a commit to peterdemaeyer/JavaHamcrest that referenced this issue Feb 21, 2021
@peterdemaeyer
hamcrest#331 Bumped source and target compatibility to Java 1.8
019e527
@night-gale night-gale mentioned this issue Apr 25, 2021
Open
@edysli
Copy link

edysli commented Jul 26, 2021

duplicates #207
see also #206

peterdemaeyer added a commit to peterdemaeyer/JavaHamcrest that referenced this issue Sep 2, 2021
@peterdemaeyer
hamcrest#331 Removed Java 1.7 from Travis build
2835692
peterdemaeyer added a commit to peterdemaeyer/JavaHamcrest that referenced this issue Sep 7, 2021
@peterdemaeyer
hamcrest#331 Attempt to work around Travis CI build issue with Oracle…
c741455 
… JDK
peterdemaeyer added a commit to peterdemaeyer/JavaHamcrest that referenced this issue Oct 3, 2021
@peterdemaeyer
Merge branch 'hamcrest#331'
bddc4c8
peterdemaeyer added a commit to peterdemaeyer/JavaHamcrest that referenced this issue Oct 3, 2021
@peterdemaeyer
Merge branch 'hamcrest#331'
c6ddf29
nhojpatrick pushed a commit to peterdemaeyer/JavaHamcrest that referenced this issue Feb 13, 2022
@peterdemaeyer @nhojpatrick
hamcrest#331 Bumped source and target compatibility to Java 1.8
a42245d
@tumbarumba tumbarumba mentioned this issue Jun 30, 2024
Closed
@tumbarumba tumbarumba self-assigned this Jun 30, 2024
tumbarumba added a commit to tumbarumba/JavaHamcrest that referenced this issue Jun 30, 2024
@tumbarumba
Merge remote-tracking branch 'upstream/hamcrest#331' into java-1.8
cd14eae
@tumbarumba tumbarumba mentioned this issue Jun 30, 2024
Merged
tumbarumba added a commit that referenced this issue Jun 30, 2024
@tumbarumba @nhojpatrick @peterdemaeyer
Java 1.8 (#411)
7b0aa98 
* #331 Bumped source and target compatibility to Java 1.8
* hamcrest v3.0-SNAPSHOT
* JUnit v5.8.2
* No longer using Travis

Co-authored-by: John Patrick <[email protected]>
Co-authored-by: Peter De Maeyer <[email protected]>
ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this issue Oct 14, 2024
@ndwlocatieservices
Merged PR 58347: Update dependency org.hamcrest:hamcrest-library to v3
1b2d751 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.hamcrest:hamcrest-library](http://hamcrest.org/JavaHamcrest/) ([source](https://github.com/hamcrest/JavaHamcrest)) | test | major | `2.2` -> `3.0` |

---

### Release Notes

<details>
<summary>hamcrest/JavaHamcrest (org.hamcrest:hamcrest-library)</summary>

### [`v3.0`](https://github.com/hamcrest/JavaHamcrest/blob/HEAD/CHANGES.md#Version-30-1st-August-2024)

[Compare Source](hamcrest/JavaHamcrest@v2.2...v3.0)

##### Breaking Changes

-   From version 3.0, the jar distributed to Maven Central is now compiled to Java 1.8 bytecode,
    and is not compatible with previous versions of Java. See
    [Issue #&#8203;331](hamcrest/JavaHamcrest#331) and
    [PR #&#8203;411](hamcrest/JavaHamcrest#411) for details. Developers who use Java 1.7 earlier can still
    depend upon `hamcrest-2.2.jar`.

##### Improvements

-   FileMatchersTest simplification ([PR #&#8203;389](hamcrest/JavaHamcrest#389))
-   License cleanup ([PR #&#8203;414](hamcrest/JavaHamcrest#414),
    [PR #&#8203;415](hamcrest/JavaHamcrest#415), see also
    [#&#8203;264](hamcrest/JavaHamcrest#264),
    [#&#8203;355](hamcrest/JavaHamcrest#355),
    [#&#8203;396](hamcrest/JavaHamcrest#396
    [#&#8203;399](hamcrest/JavaHamcrest#399))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tumbarumba tumbarumba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Java 1.8 tumbarumba/JavaHamcrest
3 participants
@tumbarumba @edysli @peterdemaeyer