base option is configurable in grunt connect task #1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimel
added a commit
that referenced
this pull request
Jun 3, 2015
|
I was unable to merge this, looks like the originating branch was deleted. I've gone ahead and made the same change manually – though I named the option just "base" (rather than "serve-base") to match "port". |
komita1981
pushed a commit
to komita1981/reveal.js
that referenced
this pull request
Aug 7, 2015
* upstream/master: (82 commits) add bower json hakimel#1067 README: suggest decktape as an alternative for PDF rendering broken <table> html in demo deck `licenses` field is deprecated enabling launching presentation with npm-start Allows to specify PORT from env on multiplex plugin add base option for grunt serve task hakimel#1102 added missing comma on the configuration example 3.1.0 consider lazy loaded iframes when formatting src fix iframe unload in firefox iframe postmesssage api works with lazy loaded iframes sync starts playing new embedded content type check to ensure we don't call media api before media has loaded fix lazy load selector error tweak to iframe lazy load test typo lazy-load iframes only for current slide, unload when hidden lazy loading fallback also considers iframes add test presentation for per-slide transitions, compile css hakimel#1106 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using reveal.js core as a submodule in my project. This approach is nice because I don't have to store reveal.js core in my repo: https://github.com/CodeCarrotsJS/szkielet-prezentacji. But problem reveals when I want to run reveal.js server using
grunt servecommand in submodule directory(src/reveal.js). What I see is thatbaseoption is hardcoded to.I made it configurable to be able to rungrunt serve --serve-base=../...