Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bower.json #1067

Closed
wants to merge 1 commit into from
Closed

Add bower.json #1067

wants to merge 1 commit into from

Conversation

teawithfruit
Copy link
Contributor

No description provided.

@cfreeley
Copy link

somebody, please merge this

@ovr
Copy link

ovr commented Jan 13, 2015

ping @hakimel

@maxmeyer
Copy link

would you mind to use https:// instead of git://? This would make using the url via coporate proxies easier.

@maxmeyer
Copy link

I think you need to make a PR agains dev branch. @hakimel Correct?

@bnjmnt4n
Copy link
Collaborator

bnjmnt4n commented Mar 3, 2015

Ping?

@hakimel
Copy link
Owner

hakimel commented Mar 3, 2015

The bower.json spec that I found (https://github.com/bower/bower.json-spec) doesn't seem to cover many of the fields included in this file, like _originalSource, _release and _resolution.

Also two things that affect this have changed since the PR was opened; the minified files are no longer included in the repo and we're at version 3.0.0.

How does the below look, anything missing or inaccurate?

{
  "name": "reveal.js",
  "version": "3.0.0",
  "main": [
    "lib/js/head.min.js",
    "js/reveal.js",
    "css/reveal.css"
  ],
  "homepage": "http://lab.hakim.se/reveal-js/",
  "license": "MIT",
  "description": "A framework for easily creating beautiful presentations using HTML.",
  "authors": [
    "Hakim El Hattab <[email protected]>"
  ],
  "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "test"
  ]
}

@hakimel hakimel changed the title added missing bower.json Add bower.json Mar 3, 2015
@maxmeyer
Copy link

maxmeyer commented Mar 3, 2015

Looks good. I think bower will complain about missing/wrong entries in this file if you try to install it.

@gion
Copy link

gion commented Mar 9, 2015

@hakimel since head.js isn't actually part of this project, it should be added as a dependency, not placed in the main field.

@hakimel
Copy link
Owner

hakimel commented Mar 25, 2015

@gion got it, will revise and add that as a dependency

@gpedro
Copy link

gpedro commented May 18, 2015

👍

hakimel added a commit that referenced this pull request Jul 2, 2015
@hakimel
Copy link
Owner

hakimel commented Jul 2, 2015

Just added a bower file in b390e66

Give it shot if you can and let me know if it's working correctly or needs to be revised.

@gion
Copy link

gion commented Jul 6, 2015

👍 works ok

komita1981 pushed a commit to komita1981/reveal.js that referenced this pull request Aug 7, 2015
* upstream/master: (82 commits)
  add bower json hakimel#1067
  README: suggest decktape as an alternative for PDF rendering
  broken <table> html in demo deck
  `licenses` field is deprecated
  enabling launching presentation with npm-start
  Allows to specify PORT from env on multiplex plugin
  add base option for grunt serve task hakimel#1102
  added missing comma on the configuration example
  3.1.0
  consider lazy loaded iframes when formatting src
  fix iframe unload in firefox
  iframe postmesssage api works with lazy loaded iframes
  sync starts playing new embedded content
  type check to ensure we don't call media api before media has loaded
  fix lazy load selector error
  tweak to iframe lazy load test
  typo
  lazy-load iframes only for current slide, unload when hidden
  lazy loading fallback also considers iframes
  add test presentation for per-slide transitions, compile css hakimel#1106
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants