fix: Add extra padding to kind and definition nodes #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values will be used to affect tree layout, without changing the rendering of individual nodes. This is essentially a workaround for the Tidy library not having support for per-edge lengths. Signed-off-by: George Thomas <[email protected]>
This avoids overlaps between highlighted nodes and dashed edges. Signed-off-by: George Thomas <[email protected]>
This avoids overlaps between siblings. Signed-off-by: George Thomas <[email protected]>
georgefst
force-pushed
the
georgefst/node-padding
branch
from
0e252f7 to
ca7b083
Compare
|
I dont know why Chromatic isn't showing any changes here. This is precisely the kind of change for which it's supposed to be useful! |
|
It's possible we've run out of minutes. I switched us back to the free plan a few months ago. |
dhess
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit fixes something which would otherwise become a much bigger problem after #1036, since kinds can then be near non-kinds. Although I haven't yet tried combining the changes. It's possible that we would then want to add vertical padding alongside the existing horizontal padding. But this would be trivial to implement now.