feat: view and edit kinds on foralls #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhess
added
Deploy service
brprice
force-pushed
the
brprice/forall-kind-edit
branch
from
adbe00a to
fe3e2f5
Compare
brprice
added
Deploy service
brprice
force-pushed
the
brprice/forall-kind-edit
branch
from
fe3e2f5 to
092902e
Compare
dhess
added
Deploy service
The new Primer pin adds a new option to EvalFull (which controls evaluation under binders), and changes the default behaviour to not evaluate under binders. Signed-off-by: Ben Price <[email protected]>
This bumps the Primer pin, which adds support for higher-kinded polymorphism. There are no other changes required to take advantage of this feature. Signed-off-by: Ben Price <[email protected]>
brprice
force-pushed
the
brprice/forall-kind-edit
branch
from
092902e to
6b5a139
Compare
brprice
changed the title
brprice
added
Deploy service
|
I've done this bump in two stages, since the earlier one introduces some changes in the orval-generated model which are orthogonal to the purpose of this PR (which is contained in the second commit). Both commits are clean bumps, with no code changes required. |
georgefst
approved these changes
Sep 26, 2023
|
@dhess mentioned he wanted to take a look at this, so I'll leave it to him to merge if/when he is happy. |
|
Given that it's literally just a pin bump (except for the upstream eval changes, which are unrelated), let's merge it, and if there are any issues down the line — and I don't expect there will be any — we'll just deal with them separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.