Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed hack-nights to events and (mostly) related cleanup #758

Conversation

drubgrubby
Copy link
Member

Fixes #748

This main part of this was renaming hack-nights.html to events.html.

In addition, there was some cleanup to related files:

Add underscores to .scss files for consistancy
Remove undescore from _main.scss
(cnk suggested the above two changes to keep naming convention consistent)
Change hack-nights-page.scss to _events.scss
Delete ../website/_includes/hack-nights.html
Moved a couple of styles from hack-nights.scss to events.scss
Added events.scss to main.scss

@drubgrubby drubgrubby requested a review from cnk September 30, 2020 03:34
@KianBadie
Copy link
Member

@cnk asked me to do a review visually on this. I did a pretty shallow visual review because I did a pretty thorough-ish review of the css classes and came to the conclusion that much shouldn't change visually because most of the classes were unique to the page on not used anywhere else. Everything looks good to me 👍

However (not because of your work @drubgrubby but I think these notes stem from things that were already existing on files related to the page):

  • .meetings-message was used/defined in project-meetings/html.scss, however they both use the same exact rules so no problem there
  • active::after is used in 2FA guide page and getting-started-page.html/scss, however the rules on the events page just reapply the same exact rules to mobile, so no problem there either
  • I know .section-hack-nights and .btn got moved to events.scss, however it is effectively imported in the same order, as events.scss is imported where these classes used to be imported. So no problem there as well as far as I can tell.

@cnk @DanielekPark I did notice a bug (that I'm pretty sure was inherited and not from your work @drubgrubby), but because active::after is defined in getting-started-page.scss for desktop views, it applies to this page as well. Which means, if you click the "Meeting Events" header under "Our Events", it will add a drop down arrow to the left of it. Click it again and it makes the content disappear. This is already on the main site, so again, it's not from this work.

Good work @drubgrubby

@cnk cnk mentioned this pull request Oct 1, 2020
2 tasks
@cnk cnk merged commit 74355fe into hackforla:gh-pages Oct 1, 2020
@drubgrubby drubgrubby deleted the dar-hack-nights-page-name-change-and-cleanup branch October 14, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hack-nights page name-change related cleanup
3 participants