Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. CSS fixes #759

Closed
2 tasks
cnk opened this issue Oct 1, 2020 · 8 comments
Closed
2 tasks

Misc. CSS fixes #759

cnk opened this issue Oct 1, 2020 · 8 comments
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing

Comments

@cnk
Copy link
Member

cnk commented Oct 1, 2020

Dependency

#577 - has been closed/completed

  • Move .meetings-message css class to an appropriate shared file and remove duplicates

  • active::after is used in 2FA guide page and getting-started-page.html/scss - move somewhere and remove dups

  • [ ] Fix another issue with active:after. Because active::after is defined in getting-started-page.scss for desktop views, it applies to events page as well. Which means, if you click the "Meeting Events" header under "Our Events", it will add a drop down arrow to the left of it. Click it again and it makes the content disappear.

(These issues were noted by @KianBadie in PR #758 )

@cnk cnk added role: front end Tasks for front end developers good first issue Good for newcomers labels Oct 1, 2020
@alexandrastubbs
Copy link
Member

@daniellen00 any update on this?

@daniellex0

This comment has been minimized.

@pawan92

This comment has been minimized.

@daniellex0 daniellex0 assigned daniellex0 and unassigned daniellen00 Jan 24, 2021
@daniellex0
Copy link
Member

Progress: I will get to this after I create shared scss files for reusable page cards and cards- components of this detail will be a little later in the process
Blockers: The other bigger reusable components in the design system need to be done before this

@pawan92

This comment has been minimized.

@trtincher trtincher added UX and removed role: front end Tasks for front end developers labels Jan 31, 2021
@daniellex0 daniellex0 removed their assignment Apr 1, 2021
@Oluwafemi-Jegede Oluwafemi-Jegede added the Dependency An issue is blocking the completion or starting of another issue label Apr 18, 2021
@sayalikotkar sayalikotkar added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 20, 2021
@ExperimentsInHonesty ExperimentsInHonesty added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Jun 20, 2021
@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency An issue is blocking the completion or starting of another issue label Jul 29, 2021
@ExperimentsInHonesty
Copy link
Member

@kristine-eudey will talk to @daniellex0 about what to do with this issue,
Is this a front end issue now?
Does this still need to be done?

@kristine-eudey
Copy link
Member

I talked with @daniellex0 who told me this should now be a front-end issue, and the developers should determine if they think these items still need to be done.

@kristine-eudey kristine-eudey added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed good first issue Good for newcomers role: design labels Aug 4, 2021
@Sihemgourou Sihemgourou added this to the z. Technical debt milestone Aug 9, 2021
@Aveline-art
Copy link
Member

This issue does not need work since the action items had been either fixed or in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing
Projects
Development

No branches or pull requests