Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Github' with 'GitHub' in assets/js/wins.js makecards #7523

Merged

Conversation

8alpreet
Copy link
Member

Fixes #7494

What changes did you make?

  • On line 334 in assets/js/wins.js, I replaced Github profile for ${card[name]} with GitHub profile for ${card[name]}. This changes the alt text of the Github icon.

Why did you make the changes (we will use this info to test)?

  • This change was made as part of a larger effort to accurately display the name "GitHub" on the website. In this context, the name will not be displayed publicly so it is for internal consistency.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • There are no visual changes to the website.

Details requested in issue

  1. Find all the files that are connected to this change

    • This changes was made in a JS file so other files are not affected
  2. Define where you expect the change to show up on the website

    • The change is not visible on the website. It's alt text for an icon so only screen readers will access the text in which case capitalization should not make a difference. Lastly, developers will see the text during code changes.
  3. Test Procedure

    This procedure is for chrome, but should be similar in other browsers.

    1. Run the website locally using docker
    2. Navigate to the wins page
    3. Right click a GitHub icon on a card in the wins page
    4. Click "inspect"
    5. Dev tools will open up to the related DOM element
    6. The alt attribute should have the value "GitHub profile for firstName lastName"
  4. Link to test procedure comment in issue: LINK

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b 8alpreet-wins-github-link-alt-text-update-7494 gh-pages
git pull https://github.com/8alpreet/website.git wins-github-link-alt-text-update-7494

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ size: 1pt Can be done in 4-6 hours labels Sep 25, 2024
@8alpreet 8alpreet changed the title Replace 'Github' with 'GitHub' in assets/js/wins.js 'makecards' Replace 'Github' with 'GitHub' in assets/js/wins.js makecards Sep 25, 2024
@buneeIsSlo buneeIsSlo self-requested a review September 25, 2024 18:08
Copy link
Member

@buneeIsSlo buneeIsSlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! @8alpreet Nice work

  • The branches from and to are setup correctly
  • Link to the issue is included
  • There is a clear and concise description of what was done and why
  • Bonus points for including a detailed test procedure
  • No visual changes were made to the website

Thanks for working on this issue!

@codyyjxn codyyjxn self-requested a review September 26, 2024 04:49
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this issue @8alpreet.
The branch name is clear the title is also very well named.
The instructions to check the change you made are clear and I was able to inspect the change on my end. Great Job! on your medium issue.

@jphamtv jphamtv merged commit c1d4085 into hackforla:gh-pages Sep 26, 2024
9 checks passed
@8alpreet
Copy link
Member Author

Thank you! @buneeIsSlo, @codyyjxn, & @jphamtv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in assets/js/wins.js makecards
4 participants