Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Github with GitHub in assets/js/wins.js makecards #7494

Closed
7 tasks done
daras-cu opened this issue Sep 19, 2024 · 3 comments · Fixed by #7523
Closed
7 tasks done

Replace Github with GitHub in assets/js/wins.js makecards #7494

daras-cu opened this issue Sep 19, 2024 · 3 comments · Fixed by #7523
Assignees
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@daras-cu
Copy link
Member

daras-cu commented Sep 19, 2024

Overview

We need to replace instances of Github and github with GitHub so that we display the company name correctly, and test the changes to ensure the behavior and appearance of any and all related webpages are unchanged.

Action Items

  • Open assets/js/wins.js in your IDE
  • In function makecards(data) change
			cloneCardTemplate.querySelector('.github-icon').alt = `Github profile for ${card[name]}`;

to

			cloneCardTemplate.querySelector('.github-icon').alt = `GitHub profile for ${card[name]}`;
  • Find all the files that are connected to this change. (e.g., if its a yml or md file, what files or scripts use the data stored in that file). And document briefly how they work together.
  • Define where you expect the change to show up on the website (e.g., the footer of the website). Can be on multiple pages
  • Write a test procedure, in a comment, and then use it to test the change. Include a link to this comment in your PR.
  • Add/commit changes then create a PR as usual. Document the test procedure in the Pull Request.

Resources

Merge Team

@daras-cu daras-cu added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ size: 1pt Can be done in 4-6 hours labels Sep 19, 2024
@daras-cu daras-cu added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 19, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 24, 2024
@8alpreet 8alpreet self-assigned this Sep 25, 2024
@HackforLABot
Copy link
Contributor

Hi @8alpreet, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@8alpreet
Copy link
Member

8alpreet commented Sep 25, 2024

Availability: weekdays 3pm - 7pm
ETA: Thu Sep 26 7pm

@8alpreet
Copy link
Member

8alpreet commented Sep 25, 2024

Test Procedure

This procedure is for chrome, but should be similar in other browsers.

  1. Run the website locally using docker
  2. Navigate to the wins page
  3. Right click a GitHub icon on a card in the wins page
  4. Click "inspect"
  5. Dev tools will open up to the related DOM element
  6. The alt attribute should have the value "GitHub profile for firstName lastName"

@8alpreet 8alpreet moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Sep 25, 2024
@github-project-automation github-project-automation bot moved this from In progress (actively working) to QA in P: HfLA Website: Project Board Sep 26, 2024
@kgold2018 kgold2018 moved this from QA to Done in P: HfLA Website: Project Board Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging a pull request may close this issue.

4 participants