removed unused variable in getDayString

[pluto-bell]

Fixes #7013

What changes did you make?

• Removed an unused variable in function getDayString in file right-col-content.js

Why did you make the changes (we will use this info to test)?

• To make the code readable, clear and uncluttered.
• This fix makes the function easier to understand for developers moving forward.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes made

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b pluto-bell-resolve-codeQL-alert#114-issue#7013 gh-pages
git pull https://github.com/pluto-bell/hack4la.git resolve-codeQL-alert#114-issue#7013

[mrodz]

Availability: Weekdays 6:30-9PM, Weekends 9AM-5PM
ETA: 13:15 8/17

[mrodz]

Hi @pluto-bell, your code changes look good!

• Removed unused variable
• Documented changes
• Explained reasoning for changes
• Resolves CodeQL alert
• Correct to branch
• Linked issue(s)

However, I believe you misread the instructions on the CodeQL issue:

Create an issue branch and proceed with the code update

This does not mean creating a new issue on top of the CodeQL issue and merging a PR to close two separate issues. Instead, make one branch associated with #7013 and develop your patch on there.

Can you please apply your changes to a branch associated with #7013, and close the extra issue (#7295)?

---

Here are some examples of merged PRs that fix CodeQL alerts:

• Remove unused import from post-comment.js #6824
• Removed Unused Variable in check-labels Action #6822
• fix: resolve CodeQL alert #6517

---

Re-request my review once you've got this done.

[pluto-bell]

Thanks @mrodz! I did misread the instructions, and that makes way more sense. I've closed out issue #7295 and editing the description of this PR.

Since the branch name is already linked to issue #7013 ("resolve-codeQL-alert#114-issue#7013") I didn't change anything there. If I'm misunderstanding what you're looking for, please let me know.

[mrodz]

I see you closed the extra issue—nice! Thanks for cleaning it up. Everything looks good to me and I think you're in a good state to merge.

For future issues, you don't need to include the # before any issue numbers. Also, you don't need to include the CodeQL alert number as prior PRs do not include it, and its CodeQL number can be obtained from the tracking issue.

Merge team, see my previous review. I am approving this issue as while the branch name does not explain the fixes, previously-merged CodeQL patches also do not relay changes in the branch name.

[jphamtv]

Hey @ihop-56, Could you please provide your estimated time for review and your availability? Thanks!

[ihop-56]

Aug 23 9 PM ET

…

On Thu, Aug 22, 2024, 3:24 PM J Pham ***@***.***> wrote: Hey @ihop-56 <https://github.com/ihop-56>, Could you please provide your estimated time for review and your availability? Thanks! — Reply to this email directly, view it on GitHub <#7296 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BA5P262NMHHZKXXUHSV3UXTZSY3IDAVCNFSM6AAAAABMSWYXTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGQ3TINJSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ihop-56]

Hi @pluto-bell, I reviewed the changes, and everything looks great. The unused variable in the getDayString function was correctly removed. There are no visual changes to the website, and the code is cleaner as a result. Nice job!