Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Unused Variable in check-labels Action #6822

Merged

Conversation

JackCasica
Copy link
Member

Fixes #6662

What changes did you make?

  • Removed unused variable results

Why did you make the changes (we will use this info to test)?

  • The variable was unused. Per the CodeQL alert:

unused local variables make code hard to read and understand. Any computation used to initialize an unused variable is wasted, which may lead to performance problems.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • Not applicable as this was a change related to a GitHub Action. As a confirmation though, I did screenshot the successful running of the action in my fork of the repository:
image

The result of the `setLabels` call is no longer assigned to variable `results` as the variable was unused.
Copy link

github-actions bot commented May 6, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b JackCasica-resolve-codeql-alert-6662 gh-pages
git pull https://github.com/JackCasica/website.git resolve-codeql-alert-6662

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium size: 1pt Can be done in 4-6 hours Feature: Code Alerts labels May 6, 2024
@t-will-gillis t-will-gillis self-requested a review May 6, 2024 18:15
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JackCasica Great work analyzing, testing, and fixing this CodeQL alert. I tested in my repo as well and agree with your code edit. Branches are good, short descriptions of what changes and why are provided, issue is linked, and code edit is clean.

Thanks!

@t-will-gillis t-will-gillis merged commit f7c9e0c into hackforla:gh-pages May 6, 2024
10 checks passed
@JackCasica JackCasica deleted the resolve-codeql-alert-6662 branch May 20, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Code Alerts role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL Alert #94 - Generated by GHA
2 participants