Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Github' to 'GitHub' in github.md #7141

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Kle012
Copy link
Member

@Kle012 Kle012 commented Jul 25, 2024

Fixes #7110

What changes did you make?

  • Change 'Github' to 'GitHub' in redirections/github.md

Why did you make the changes (we will use this info to test)?

  • Make sure company name GitHub displays with proper capitalization throughout the website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes

Connected file

  • The github.md is used to redirect the link https://www.hackforla.org/github to -> https://www.github.com/hackforla in the _layouts/redirect.html page. However, the template never references the title: Github element that has been edited. Therefore, there should be no visual changes to the page, and it redirects correctly as intended.

Test

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Kle012-replace-github-7110 gh-pages
git pull https://github.com/Kle012/website.git replace-github-7110

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Navigation size: 1pt Can be done in 4-6 hours labels Jul 25, 2024
@ha-bach ha-bach self-requested a review July 28, 2024 20:04
@ha-bach
Copy link
Member

ha-bach commented Jul 28, 2024

Reviewing this PR
ETA: end of day
Availability: Sunday, Monday.

Copy link
Member

@ha-bach ha-bach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kle012,

  • branching looks good
  • relevant issue is linked
  • code edit is clean
  • on my machine, hackforla.org/github redirects to github.com/hackforla without issue

Great job on this issue, and thanks for contributing!

@t-will-gillis
Copy link
Member

Hi @daras-cu, @buneeIsSlo, @Kle012, and @taylorbeee Just a friendly reminder- Since each of your open PRs are similar, you can help the review process move along by reviewing each other’s PRs. Thanks!

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kle012, your changes look good:

  • Branches set correctly
  • Issue is linked in PR
  • Includes explanation of changes and testing procedure for reviewers
  • Change to file made correctly and page redirects to GitHub when testing

Well done!

@t-will-gillis t-will-gillis merged commit 93dfcb5 into hackforla:gh-pages Jul 31, 2024
6 checks passed
@Kle012 Kle012 deleted the replace-github-7110 branch August 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Navigation role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

replace Github with GitHub in website/redirections/github.md
4 participants