Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Github with GitHub in website/redirections/github.md #7110

Closed
7 tasks done
roslynwythe opened this issue Jul 15, 2024 · 4 comments · Fixed by #7141
Closed
7 tasks done

replace Github with GitHub in website/redirections/github.md #7110

roslynwythe opened this issue Jul 15, 2024 · 4 comments · Fixed by #7141
Assignees
Labels
Complexity: Medium P-Feature: Navigation role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jul 15, 2024

Overview

We need to replace Github with GitHub so that the company name is displayed correctly, and we need to test the changes to ensure the behavior and appearance of the website unchanged.

Action Items

  • Open redirections/github.md in your IDE
  • Change
title: Github

to

title: GitHub
  • Find all the files that are connected to this change. (e.g., if its a yml or md file, what files or scripts use the data stored in that file). And document briefly how they work together.
  • Define where you expect the change to show up on the website (e.g., the footer of the website). Can be on multiple pages
  • Write a test procedure, in a comment, and then use it to test the change. Include a link to this comment in your PR.
  • Add/commit changes then create a PR as usual. Document the test procedure in the Pull Request.

Resources

Merge Team

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 15, 2024
Copy link

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

  • Complexity, Role, Feature, Size

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added Complexity: Medium role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours P-Feature: Navigation Feature: API Coding requires using an API Ready for Prioritization and removed Feature: API Coding requires using an API Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 15, 2024
@roslynwythe roslynwythe changed the title replace Github with GitHub in replace Github with GitHub in website/redirections/github.md Jul 15, 2024
@roslynwythe roslynwythe added the role: front end Tasks for front end developers label Jul 15, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval to Prioritized backlog in P: HfLA Website: Project Board Jul 20, 2024
@Kle012 Kle012 self-assigned this Jul 23, 2024
@HackforLABot
Copy link
Contributor

Hi @Kle012, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Kle012 Kle012 moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Jul 23, 2024
@Kle012
Copy link
Member

Kle012 commented Jul 23, 2024

i. Availability: EOD
ii. ETA: within this week

@Kle012 Kle012 changed the title replace Github with GitHub in website/redirections/github.md replace Github with GitHub in redirections/github.md Jul 25, 2024
@Kle012 Kle012 changed the title replace Github with GitHub in redirections/github.md replace Github with GitHub in /website/redirections/github.md Jul 25, 2024
@Kle012 Kle012 changed the title replace Github with GitHub in /website/redirections/github.md replace Github with GitHub in website/redirections/github.md Jul 25, 2024
@Kle012
Copy link
Member

Kle012 commented Jul 25, 2024

Connected file
The github.md is used to redirect the link https://www.hackforla.org/github to -> https://www.github.com/hackforla in the _layouts/redirect.html page. However, the template never references the title: Github element that has been edited. Therefore, there should be no visual changes to the page, and it redirects correctly as intended.

Test
Compare the http://localhost:4000/github to the live page on the HfLA website https://www.hackforla.org/github
Check for visual changes, found none
Redirects correctly to the github link

@github-project-automation github-project-automation bot moved this from In progress (actively working) to QA in P: HfLA Website: Project Board Jul 31, 2024
@kgold2018 kgold2018 moved this from QA to Done in P: HfLA Website: Project Board Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Navigation role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging a pull request may close this issue.

4 participants