Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved codeql alert 98 #6566

Merged

Conversation

nelsonuprety1
Copy link
Member

@nelsonuprety1 nelsonuprety1 commented Apr 4, 2024

Fixes #6309

What changes did you make?

  • Moved the attribute rel="noopener noreferrer" from the img to a tag.

Why did you make the changes (we will use this info to test)?

  • To resolve the alert "Potentially unsafe external link"

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Moving files to another directory. No visual changes to the website.

Visuals after changes are applied

Moving files to another directory. No visual changes to the website.

Copy link

github-actions bot commented Apr 4, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nelsonuprety1-resolve-codeql-alert-6309 gh-pages
git pull https://github.com/nelsonuprety1/website.git resolve-codeql-alert-6309

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/nelsonuprety1/website/blob/resolve-codeql-alert-6309/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: back end/devOps Tasks for back-end developers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 0.25pt Can be done in 0.5 to 1.5 hours Feature: Code Alerts labels Apr 4, 2024
@nelsonuprety1 nelsonuprety1 requested review from aidanwsimmons and roslynwythe and removed request for aidanwsimmons April 4, 2024 20:50
Copy link
Member

@aidanwsimmons aidanwsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nelson- changes made to the code look good, issue linked correctly and branches look correct.
Just requesting a couple edits to your pr description to clean it up a bit:

  • in changes made:
    include tag names ( a, img ) instead of "from the tag to the tag"

  • in why did you make the changes:
    change to the following: to resolve the alert "Potentially unsafe external link"
    i think you may have misinterpreted the issues first action item as the need for these changes. The checkbox is what is used to establish tracking between the issue and the alert.

  • for the visual changes- since nothing is changing visually, you can just put something similar to the following example from contributing.md 3.1.b:

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Moving files to another directory. No visual changes to the website.

@aidanwsimmons
Copy link
Member

Availability: weekday afternoons
ETA: EOD today

@nelsonuprety1
Copy link
Member Author

@aidanwsimmons I have changed as per your request. Please kindly do check , thank you.

Copy link
Member

@aidanwsimmons aidanwsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good- nice work. issue linked correctly and branches look good. Good descriptions of changes.

@freaky4wrld freaky4wrld requested review from freaky4wrld and removed request for roslynwythe April 10, 2024 05:02
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonuprety1 thanks for taking up the issue, branch looks good, changes made are correct and you mentioned things as required.

PR approved!!

@freaky4wrld freaky4wrld merged commit 4d0ec3c into hackforla:gh-pages Apr 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Code Alerts good first issue Good for newcomers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL alert 98 "Potentially unsafe external link"
3 participants