-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved codeql alert 98 #6566
Resolved codeql alert 98 #6566
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Nelson- changes made to the code look good, issue linked correctly and branches look correct.
Just requesting a couple edits to your pr description to clean it up a bit:
-
in changes made:
include tag names ( a, img ) instead of "from the tag to the tag" -
in why did you make the changes:
change to the following: to resolve the alert "Potentially unsafe external link"
i think you may have misinterpreted the issues first action item as the need for these changes. The checkbox is what is used to establish tracking between the issue and the alert. -
for the visual changes- since nothing is changing visually, you can just put something similar to the following example from contributing.md 3.1.b:
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Moving files to another directory. No visual changes to the website.
Availability: weekday afternoons |
@aidanwsimmons I have changed as per your request. Please kindly do check , thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good- nice work. issue linked correctly and branches look good. Good descriptions of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelsonuprety1 thanks for taking up the issue, branch looks good, changes made are correct and you mentioned things as required.
PR approved!!
Fixes #6309
What changes did you make?
img
toa
tag.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Moving files to another directory. No visual changes to the website.
Visuals after changes are applied
Moving files to another directory. No visual changes to the website.