Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CodeQL alert 98 "Potentially unsafe external link" #6309

Closed
4 of 7 tasks
Tracked by #5129
t-will-gillis opened this issue Feb 17, 2024 · 2 comments · Fixed by #6566
Closed
4 of 7 tasks
Tracked by #5129

Resolve CodeQL alert 98 "Potentially unsafe external link" #6309

t-will-gillis opened this issue Feb 17, 2024 · 2 comments · Fixed by #6566
Assignees
Labels
Feature: Code Alerts good first issue Good for newcomers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented Feb 17, 2024

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to resolve the alert "Potentially unsafe external link" which appears in the CodeQL alert 98 by moving the attribute rel="noopener noreferrer" from the <img> tag to the <a> tag.

Action Items

  • The following item is required for GitHub to establish tracking between this issue and the alert. No action is required. You may simply check the checkbox. If you do follow the link to learn more about CodeQL alerts, DO NOT DISMISS THE ALERT.
  • https://github.com/hackforla/website/security/code-scanning/98
  • Open the file pages/communities-of-practice.html in your IDE
  • On line 50, replace:
<a href='{{ leader.links.github }}' target='_blank' title='GitHub Profile'><img class='leader-img--communities' src='{{ leader.picture }}' rel='noopener noreferrer'/></a>

with

<a href='{{ leader.links.github }}' target='_blank' title='GitHub Profile' rel='noopener noreferrer' ><img class='leader-img--communities' src='{{ leader.picture }}' /></a>
  • The scope of this issue is only for the code identified in CodeQL alert 98.
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Merge Team

Resources/Instructions

  1. GitHub CodeQL documentation
  2. Webpage: https://www.hackforla.org/communities-of-practice
  3. This issue is a correction of Resolve CodeQL alert 20 "Potentially unsafe external link" #6054, and is a part of Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129
Copy link

github-actions bot commented Apr 4, 2024

Hi @nelsonuprety1, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@nelsonuprety1
Copy link
Member

Please check #6566 . Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Code Alerts good first issue Good for newcomers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

5 participants