Accomplishments edit by year 4188 #5932
Conversation
…different-years-4188 accomplishments-year-check
…ccomplishments-edit-by-year-4188
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
Thinking-Panda
added
role: front end
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
NOTE TO REVIEWERS & MERGE TEAM: I have added sample accomplishments to test for different years. After the PR is reviewed, I can clean up the sample accomplishments before merging. |
|
ETA: 11/28 |
|
Hi @mademarc! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. Thanks! |
There was a problem hiding this comment.
Hey @Thinking-Panda, great job tackling this large issue!
- Year & Program Area/Project Files fields have been added to all the accomplishments.
- Accomplishment section on the About page has been changed to include an option to view accomplishments from different years.
- Accomplishments are listed by program area.
I have a few requested changes. Both these findings don't break the functionality of the new design, but if they can be fixed that would be great!
- When the window is resized from desktop to mobile view, or vice versa, the selected year doesn't stay consistent. For example: if you select "2022" in desktop view, then resize to mobile view, it shows "All" in the dropdown menu even though the 2022 results are still displayed.
- The cursor changes to the text-select icon when hovering over the years. This might be confusing since they are links.
|
Thank you @kwangric for the review. I will work on it and push the changes soon. |
|
Review ETA: 11/30/2023 |
There was a problem hiding this comment.
Hey @Thinking-Panda good call on the yml, js & scss file changes and @LRenDO the ETA and Availability is there.
There was a problem hiding this comment.
Hey @Thinking-Panda Excellent work on this issue and great back and forth with @kwangric addressing comments! In mobile, tablet, and desktop in Docker, the code edits appear to satisfy the requirements of 4188 and the intent shown on Figma with the minor edits to the subheaders for the program areas as noted.
Super work again and thanks for taking on this issue
Fixes #4188
What changes did you make?
accomplishments.ymlabout.jsto retrieve data, sort accomplishments and filter by year_about.scssWhy did you make the changes (we will use this info to test)?
accomplishments.yml- added project-file if existed and program-area if project file does not existabout.js- added functions to display years for accomplshments, retrieve data from YAML file, handle click events and display accomplishments by yearabout.html- to pass the variable {{accomplishments}} through a<script>tagScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied