accomplishments-year-check #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hackforla#4188
What changes did you make?
accomplishments.yml, added year, program-area or project-file to existing accomplishments.about.js, added code to display accomplishments for the year chosen.about-card-accomplishments.html, added script tag to pass {accomplishments} variable.Why did you make the changes (we will use this info to test)?
accomplishments.yml- addedproject-file:if a file existed andprogram-area:if no project file existed.about.js- added functions to receive data from the YAML file, include program-area to accomplishments, sort accomplishments by program-area, and filter by year before displaying.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied