-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Found the superfluous empty class attribute in _guide-pages/2FA.html … #5907
Found the superfluous empty class attribute in _guide-pages/2FA.html … #5907
Conversation
…at line 50. Deleted the empty class attribute
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Availability: Weekdays 6-9pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Luke!
Great work on your PR
• you created a branch with the correct syntax and committed to gh-pages
• Going over your linked issue I am able to understand the the changes you made to _guide-pages/2FA.html
• I see you removed the unused class attribute from the div tag on line 50
Visually everything looks good. the only tip I would give you is to remove any unused bullet points from the pull request template
Availability: M-F, 5-8 PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Your PR is done with the correct branch.
- Your code is correctly changed.
Reviewed and approved!
Great work @LukeLowrey2
Fixes #5712
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
There were no visual changes to the website