Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute appears to be superfluous in _guidepages/2FA.html #5712

Closed
3 of 4 tasks
roslynwythe opened this issue Oct 16, 2023 · 6 comments · Fixed by #5907
Closed
3 of 4 tasks

attribute appears to be superfluous in _guidepages/2FA.html #5712

roslynwythe opened this issue Oct 16, 2023 · 6 comments · Fixed by #5907
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Oct 16, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

Determine whether or not an empy class attribute in _guidepages/2FA.html is superflous, and if so, remove it.

Action Items

  • In your local IDE, navigate to _guidepages/2FA.html at or near line 50, and note the line of code
<div class=''>

  • Determine whether the class attribute is superflous (unnecessary).
    • If so, remove it, then perform local testing using docker to ensure that the behavior and appearance of the page is unchanged, and then proceed to create a Pull Request
    • If the HTML should remain as-is, explain in a comment in the issue, then move the issue to Questions/In Review and apply the 'ready for dev lead' label.

Resources/Instructions

  1. For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/_guidepages/2FA.html
  2. Webpage: https://www.hackforla.org/guide-pages/2FA
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Oct 16, 2023
@github-actions

This comment was marked as resolved.

@roslynwythe roslynwythe added Complexity: Medium role: front end Tasks for front end developers Feature: Refactor HTML size: 1pt Can be done in 4-6 hours Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing Complexity: Medium size: 1pt Can be done in 4-6 hours labels Oct 16, 2023
@LukeLowrey2 LukeLowrey2 self-assigned this Oct 24, 2023
@github-actions
Copy link

Hi @LukeLowrey2, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@LukeLowrey2
Copy link
Member

Availability: Wednesday 10/25/23 10am-12pm, Thursday 10/26/23 10am-12pm, Sunday 10/29/23 9am-12pm, Monday 10/30/23 11am-1pm

ETA: Monday 10/30/23 EOD

@LukeLowrey2
Copy link
Member

Progress: I found the superfluous empty class attribute in _guide-pages/2FA.html at line 50. I deleted the empty class attribute. I saw no changes to behavior or appearance when testing locally.

Blockers: No blockers

Availability: Sunday 10/29/2023 9am-11am, Monday 10/30/2023 9am-11am

ETA: Issue is complete and waiting on pull request approval

@roslynwythe
Copy link
Member Author

Great job @LukeLowrey2 please proceed with pull request. Thank you.

@ExperimentsInHonesty ExperimentsInHonesty added this to the x. Technical debt milestone Nov 6, 2023
@LukeLowrey2
Copy link
Member

Blocker: Unable to work around an unwanted file change in the pull request. I will be asking for assistance at the next meeting I can attend.

Availability: Tuesday 11/7/23 5pm-7pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
3 participants