Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to img tag #5701

Merged

Conversation

naveenmallemala5
Copy link
Member

@naveenmallemala5 naveenmallemala5 commented Oct 11, 2023

Fixes #5621

What changes did you make?

  • I made a change to an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>).

Why did you make the changes (we will use this info to test)?

  • I made change, so that the codebase is consistent with how we use img HTML tags.

Testing

  • I tested the code changes and everything looks good.

For Reviewer

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b naveenmallemala5-img-tag-refactor-5621 gh-pages
git pull https://github.com/naveenmallemala5/HLA_website.git img-tag-refactor-5621

@naveenmallemala5 naveenmallemala5 changed the title Changed img tag Changed Care img tag Oct 11, 2023
@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 11, 2023
@blulady blulady requested review from tonyvang and k-rewd October 11, 2023 02:33
@naveenmallemala5 naveenmallemala5 changed the title Changed Care img tag Changes to img tag Oct 11, 2023
@tonyvang
Copy link
Contributor

tonyvang commented Oct 11, 2023

Hi, PR Review incoming as discussed in tonight's mtg. Availability: Thursday after 6:00PST, Saturday AM & Sunday PM
ETA: Sunday, Oct 15, end of day

Copy link
Member

@k-rewd k-rewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! HTML img tag's ending slash has been properly removed per instructions. PR properly links changes to the CONTRIBUTING.md doc. Visual changes aren't applicable here but the image is still linked properly. Tags are correct. Issue has been moved to the "in progress" column as requested by @LRenDO comment. Awesome!

Copy link
Contributor

@tonyvang tonyvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Naveenmallemala5,

Your pull request appears correctly branched.

Your code change is appropriate for the issue, and is clearly explained. The linked CONTRIBUTING.md from your fork looks identical to the live page as expected.

Great work! Approved.

@t-will-gillis t-will-gillis merged commit a0c0de5 into hackforla:gh-pages Oct 15, 2023
11 of 15 checks passed
@naveenmallemala5 naveenmallemala5 deleted the img-tag-refactor-5621 branch October 17, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Wiki good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img tag refactor in CONTRIBUTING.md Section 3.1.b v
4 participants