Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img tag refactor in CONTRIBUTING.md Section 3.1.b v #5621

Closed
4 tasks done
Tracked by #5040 ...
roslynwythe opened this issue Sep 28, 2023 · 3 comments · Fixed by #5701
Closed
4 tasks done
Tracked by #5040 ...

img tag refactor in CONTRIBUTING.md Section 3.1.b v #5621

roslynwythe opened this issue Sep 28, 2023 · 3 comments · Fixed by #5701
Assignees
Labels
Feature: Wiki good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 28, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Action Items

  • In your local IDE, navigate to CONTRIBUTING.md
  • Replace
<img src="https://user-images.githubusercontent.com/81049661/161181526-23ae511c-e991-4cc6-a0a4-d8db19dd69ca.png"/>

with

<img src="https://user-images.githubusercontent.com/81049661/161181526-23ae511c-e991-4cc6-a0a4-d8db19dd69ca.png">
  • Changes to CONTRIBUTING.md cannot be tested locally, rather they must be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL. Also store the test URL for use in a later step:
https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md

(for example: https://github.com/bonniewolfe/website/blob/issue-branch-1234/CONTRIBUTING.md)

  • Create a pull request with your changes. In the Pull Request, after the "Why did you make the changes" section, add this line to help reviewers, replacing the text in brackets (and the brackets) with the test URL from the previous Action Item.
For Reviewers: Do not review changes locally, rather, review changes at [REPLACE WITH TEST URL]

Resources/Instructions

CONTRIBUTING.md
Getting started with writing and formatting on GitHub

@roslynwythe roslynwythe added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less good first issue Good for newcomers and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Sep 28, 2023
@github-actions github-actions bot added Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed good first issue Good for newcomers labels Sep 28, 2023
@roslynwythe roslynwythe added size: 0.25pt Can be done in 0.5 to 1.5 hours and removed size: 0.5pt Can be done in 3 hours or less labels Sep 28, 2023
@roslynwythe roslynwythe added good first issue Good for newcomers Ready for Prioritization and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Sep 29, 2023
@anjolaaoluwa anjolaaoluwa added this to the x. Technical debt milestone Oct 1, 2023
@naveenmallemala5 naveenmallemala5 self-assigned this Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Hi @naveenmallemala5, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@naveenmallemala5
Copy link
Member

i. Availability: Wednesday (10/04/2023)-Tuesday (10/10/2023). Please contact me anytime on Slack if there are questions on this issue. I should respond quickly.
ii. ETA: Tuesday(10/10/2023) - EOD.

@LRenDO
Copy link
Member

LRenDO commented Oct 11, 2023

Hi @naveenmallemala5! It looks like there is a pull request for this issue and I don't see an question here. It looks like maybe you moved it in the column because it is in review. Issues that have pull requests associated with them don't need to be moved to this column unless you have a question. There are sometimes issues that don't have pull requests associated with them and those will need to be moved to this column. This is a little unclear in the workflow. Until the pull request is merged, this issue stays in the In progress (actively working) column and should automatically close once the pull request is merged. If I have assumed incorrectly and you had a question, please feel free to move it back to the Questions / In Review column and add a question in the comments here. If you have any questions, feel free to ping me! Thanks for working on the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Wiki good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

5 participants